? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
1 Aug 2015

As title says. See testing procedure in #7608

Before patch:
screen shot 2015-08-01 at 10 46 53

After patch:
screen shot 2015-08-01 at 11 47 00

avatar infograf768 infograf768 - open - 1 Aug 2015
avatar infograf768 infograf768 - change - 1 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2015
Labels Added: ?
avatar Fedik
Fedik - comment - 2 Aug 2015

not sure, maybe I missed something,
but for me here no issue, it works with old z-index value (tried in Chrome and Firefox in j3.4.4):
screen 2015-08-02 11 53 34 414x400

also I see that #status bar has z-index: 1030 https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/css/template.css#L3339

avatar Fedik
Fedik - comment - 2 Aug 2015

UPD
I just tested on j 3.4.3 and there I got the described issue,
but seems it already fixed in 3.4.4 , in some way,
someone else can confirm?

ok, yes, it seems fixed:
in j3.4.3 #status has z-index: 1050;
in j3.4.4 #status has z-index: 1030;

avatar infograf768
infograf768 - comment - 2 Aug 2015

This is not the z-index I get for the status bar. in edit module
It is z-index 1050 here:
screen shot 2015-08-02 at 11 09 39

avatar infograf768
infograf768 - comment - 2 Aug 2015

My test is on 3.4.4 dev

avatar infograf768
infograf768 - comment - 2 Aug 2015

Looks like the test has to be done on a multilang site.
inside the div status, we do have a div multiLangModal with class modal
That class contains z-index 1050
The code is there because the multilangstatus module is displayed

Therefore my PR solves the issue here and has no bad effect in monolanguage

avatar Fedik
Fedik - comment - 2 Aug 2015

hm, very strange, maybe I realy something missed
but you seen? https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/css/template.css#L3339 it is 1030

avatar Fedik
Fedik - comment - 2 Aug 2015

ok, I understand :smile:

avatar infograf768
infograf768 - comment - 2 Aug 2015

One more tester!

avatar Fedik
Fedik - comment - 2 Aug 2015

I can reproduce the issue when enable module "Language status",
seems, this module add:

.navbar-fixed-bottom {
    z-index: 1050;
}

maybe we can just remove it there?

avatar Fedik Fedik - test_item - 2 Aug 2015 - Tested successfully
avatar Fedik
Fedik - comment - 2 Aug 2015

it was introduced in #4575 ... @dgt41 can you check is it still need there?

avatar infograf768
infograf768 - comment - 2 Aug 2015

We need to keep the z-index 1050 in div modal as it is a bootstrap css
https://github.com/joomla/joomla-cms/blob/staging/media/jui/css/bootstrap.css#L6138-L6159

BTW, I took off the line here: https://github.com/joomla/joomla-cms/blob/staging/administrator/modules/mod_multilangstatus/tmpl/default.php#L15 and it does not work:
screen shot 2015-08-02 at 11 46 33

as the issue remains, It is easier imho to just increase the z-index as proposed in this PR.

avatar Fedik
Fedik - comment - 2 Aug 2015

ok, I just thought we can make "all in one place", for avoid confusing in future :smile:

Current patch still good, anyway :wink:

avatar infograf768
infograf768 - comment - 2 Aug 2015

My mistake... changed code on another test site.

The issue is different if we take off that line in the multilangstatus module: it displays the modal all greyed

avatar zero-24 zero-24 - change - 2 Aug 2015
Category Templates (admin)
avatar dgt41
dgt41 - comment - 2 Aug 2015

Works ok here

avatar dgt41
dgt41 - comment - 2 Aug 2015

@Fedik the problem was that multilingual status modules is by default assigned to the bottom bar and the z-index made it unusable since the modal will remained hidden…. I didn’t realize at that time that this will backfire for chosen lists

avatar dgt41
dgt41 - comment - 2 Aug 2015

@infograf768 @Fedik shall we move multilane status from the bottom bar to cpanel? Will solve some inconsistencies, that still exist (e.g. reducing the browser width makes the modal go away)

avatar Fedik
Fedik - comment - 2 Aug 2015

@dgt41 for me it is fine where it is now :wink:

avatar infograf768
infograf768 - comment - 2 Aug 2015

Moving the multilanguagestatus module to CPanel was considered and rejected when we implemented this feature as ot may be needed at any time when working on multilang (setting languagefilter plugin, setting switcher module(s), setting content languages, setting Home menu items).

2 good tests: Please RTC for 3.4.4

avatar dgt41
dgt41 - comment - 2 Aug 2015

@infograf768 ahh ok, I didn’t know that

avatar infograf768 infograf768 - change - 2 Aug 2015
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 2 Aug 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7609.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2015
Labels Added: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 3 Aug 2015

Thank you, @infograf768!

avatar Kubik-Rubik Kubik-Rubik - close - 3 Aug 2015
avatar joomla-cms-bot joomla-cms-bot - close - 3 Aug 2015
avatar Kubik-Rubik Kubik-Rubik - change - 3 Aug 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-08-03 08:54:49
Closed_By Kubik-Rubik
avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment