User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
UPD
I just tested on j 3.4.3 and there I got the described issue,
but seems it already fixed in 3.4.4 , in some way,
someone else can confirm?
ok, yes, it seems fixed:
in j3.4.3 #status
has z-index: 1050;
in j3.4.4 #status
has z-index: 1030;
My test is on 3.4.4 dev
Looks like the test has to be done on a multilang site.
inside the div status, we do have a div multiLangModal with class modal
That class contains z-index 1050
The code is there because the multilangstatus module is displayed
Therefore my PR solves the issue here and has no bad effect in monolanguage
hm, very strange, maybe I realy something missed
but you seen? https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/css/template.css#L3339 it is 1030
ok, I understand
One more tester!
I can reproduce the issue when enable module "Language status",
seems, this module add:
.navbar-fixed-bottom {
z-index: 1050;
}
maybe we can just remove it there?
that does not looks very usefull https://github.com/joomla/joomla-cms/blob/staging/administrator/modules/mod_multilangstatus/tmpl/default.php#L15
We need to keep the z-index 1050 in div modal as it is a bootstrap css
https://github.com/joomla/joomla-cms/blob/staging/media/jui/css/bootstrap.css#L6138-L6159
BTW, I took off the line here: https://github.com/joomla/joomla-cms/blob/staging/administrator/modules/mod_multilangstatus/tmpl/default.php#L15 and it does not work:
as the issue remains, It is easier imho to just increase the z-index as proposed in this PR.
ok, I just thought we can make "all in one place", for avoid confusing in future
Current patch still good, anyway
My mistake... changed code on another test site.
The issue is different if we take off that line in the multilangstatus module: it displays the modal all greyed
Category | ⇒ | Templates (admin) |
Works ok here
@infograf768 @Fedik shall we move multilane status from the bottom bar to cpanel? Will solve some inconsistencies, that still exist (e.g. reducing the browser width makes the modal go away)
Moving the multilanguagestatus module to CPanel was considered and rejected when we implemented this feature as ot may be needed at any time when working on multilang (setting languagefilter plugin, setting switcher module(s), setting content languages, setting Home menu items).
2 good tests: Please RTC for 3.4.4
@infograf768 ahh ok, I didn’t know that
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Thank you, @infograf768!
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-03 08:54:49 |
Closed_By | ⇒ | Kubik-Rubik |
Labels |
Removed:
?
|
not sure, maybe I missed something,
but for me here no issue, it works with old z-index value (tried in Chrome and Firefox in j3.4.4):
also I see that
#status
bar hasz-index: 1030
https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/css/template.css#L3339