? Success

User tests: Successful: Unsuccessful:

avatar justinherrin
justinherrin
31 Jul 2015

Just like the /administrator login screen, this will make the Username field be autofocus and ready to type in to. This is for the frontend com_users login view.

avatar justinherrin justinherrin - open - 31 Jul 2015
avatar justinherrin justinherrin - change - 31 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2015
Labels Added: ?
avatar Achal-Aggarwal
Achal-Aggarwal - comment - 31 Jul 2015

If you want to make username field autofocus, you can set autofocus attribute to true in it's xml.

avatar justinherrin
justinherrin - comment - 31 Jul 2015

Thanks @Achal-Aggarwal for pointing that out, it sounds much easier that way :+1:

avatar justinherrin
justinherrin - comment - 31 Jul 2015

So clearly I jumped the gun here with this PR and would like to suggest editing a different file instead of the one edited in here. Is there a simple way to do that within this PR or would it be best to Close this PR and open a brand new one?

Sorry, I'm still pretty new to Github :-/

avatar Fedik
Fedik - comment - 31 Jul 2015

good idea, but you do not need to use any javascript here at all http://www.w3schools.com/tags/att_input_autofocus.asp

just do what @Achal-Aggarwal wrote :wink:
edit components/com_users/models/forms/login.xml and add autofocus="true" for the username field

you can do new pull, and close this one if you like ... here no problem with this :wink:

avatar Achal-Aggarwal
Achal-Aggarwal - comment - 31 Jul 2015

Straightforward way is, close this PR, delete the branch patch-2 and start from the beginning.

Another possible way is, amend this commit and force push branch patch-2.

avatar justinherrin justinherrin - close - 31 Jul 2015
avatar justinherrin
justinherrin - comment - 31 Jul 2015

Thanks for the information about the Github protocols @Achal-Aggarwal and @Fedik. I'm closing this PR now to do a proper one on the XML file now.

avatar justinherrin justinherrin - change - 31 Jul 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-07-31 17:18:42
Closed_By justinherrin
avatar justinherrin justinherrin - close - 31 Jul 2015
avatar justinherrin justinherrin - head_ref_deleted - 31 Jul 2015

Add a Comment

Login with GitHub to post a comment