code doesn't looks bad, the query should be changed to

$query = $db->getQuery(true);

$query->delete('#__redirect_links')->where($db->qn('published') . '<> 1');

$db->setQuery($query);

I tested out your code... a nice and welcomed feature if you ask me. I did notice a few things though...

1. If I had links that were marked as "Archived" status, those also got deleted when I hit the new "Purge" button. I would guess that some folks might want to keep "Archived" links and not have them be purged out.
2. If the feature is meant to purge out "Archived" links as well, can you update the COM_REDIRECT_CLEAR_SUCCESS language string success message to say "All unpublished, archived, and trashed links have been successfully deleted."?

To be perfectly honest I didnt even know you could have a status of anything other than enabled/disabled as com_redirects list view really doesnt follow the same behaviour as other components.

My personal view is that it should probably only remove unpublished/disabled links which means that the query needs changing and not the strings - I guess it depends on what others think.

My personal view is that it should probably only remove unpublished/disabled links which means that the query needs changing and not the strings

I agree with that as well.

I then would suggest updating the models/links.php query delete line to be...

$query->delete('#__redirect_links')->where($db->qn('published') . '= 0');

didn't thought about it but a "anything = 0" is much more better

Should also be faster I think. At least in theory.

Whatever you decide I will update just let me know

On 30 July 2015 at 18:41, Thomas Hunziker notifications@github.com wrote:

Should also be faster I think. At least in theory.

—
Reply to this email directly or view it on GitHub
#7586 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

$query->delete('#__redirect_links')->where($db->qn('published') . '= 0'); is correct if it should only delete unpublished items. Which I think is the most useful behavior.

I have updated the query as suggested

I think we can improve the code a bit. Instead of store the message in the model and use it in controller (via _message property), the purge method in model should only return true or false. Then the purge method in controller can check and return value of the model and display the corresponding message.

@joomdonation perhaps but this code is written exactly the same way as similar functionality already in the core

I have just tested it successfully! Very nice feature.
I also tested, that "archived" links are not deleted with the new Purge Button.

1) Enabled Redirect Plugin and "Collect URLs"
2) Opened Frontend and created fake URLs
3) Marked some of them in the Redirect Plugin as "archived"
4) Clicked on the Button "Purge Unpublished"
5) Only the "unpublished" links were deleted

@brianteeman I made a PR brianteeman#15 to show how the code should look like. I think it's better then the original code (not sure where you see that code in Joomla core but I guess there is not much code like that). Hope the maintainer who check this PR will decide what code to use.

You can find it in com_installer, com_joomlaupdate

On 26 August 2015 at 15:49, Tuan Pham Ngoc notifications@github.com wrote:

@brianteeman https://github.com/brianteeman I made a PR brianteeman#15
brianteeman#15 to show how the code
should look like. I think it's better then the original code (not sure
where you see that code in Joomla core but I guess there is not much code
like that). Hope the maintainer who check this PR will decide what code to
use.

—
Reply to this email directly or view it on GitHub
#7586 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

I tested the purge like @kathastaden. It was successfull and worked like expected

I've merged the contribution from @joomdonation - I guess it needs retesting now

It works. Great job. Thanks.

Works great thanks @brianteeman moving to RTC based on the lest testing.

Thanks everybody, merged into 3.5-dev with commit 26d8f45