? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 Jul 2015

It has become apparent that in some translations the word "installation" has been translated when it refers to the folder named "installation" and should not have been translated.

This PR add a line comment for translators to inform them not to translate this word on the specific lines in the installation language files

This should be displayed when using com_localise to create joomla translation packages as stated by @infograf768

I have updated all the en-* installation languages and the string added is

; The word 'installation' should not be translated as it is a physical folder.

avatar brianteeman brianteeman - open - 29 Jul 2015
avatar brianteeman brianteeman - change - 29 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2015
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2015
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 29 Jul 2015

I suggested, instead of adding the comment each time it concerns a folder, to only add it once before the first string where 'installation' concerns the folder.
Also the text should be, to avoid confusion:
; The word 'installation' should not be translated when it is a physical folder.

TTs will understand when it is a folder or not.
I also suggested to use single quotes around the word in that case to make it even clearer.

avatar infograf768
infograf768 - comment - 29 Jul 2015

See my original comments here:
#7523 (comment)

#7523 (comment)

avatar brianteeman
brianteeman - comment - 29 Jul 2015

Sorry if I misunderstood your comment I thought com_localise would only
show the comment if it was on the line preceding the string. Thats why I
added it multiple times before each occurrence. I dont see any harm in it
being there each time as it will also be useful for people translating
manually.

If it used each time then there is need to change the comment.

Also clearly TT are not understanding "when it is a folder or not" and that
it should not be translated as a quick check showed only 10 non-en
languages were not translating the name of the folder

On 29 July 2015 at 10:28, infograf768 notifications@github.com wrote:

See my original comments here:
#7523 (comment)
#7523 (comment)

#7523 (comment)
#7523 (comment)


Reply to this email directly or view it on GitHub
#7577 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 29 Jul 2015

I will leave this to the CMS maintainers to decide how to best proceed with correcting the bad translations

avatar infograf768
infograf768 - comment - 29 Jul 2015

Maybe I explained badly: TTs will understand easily when it is a folder IF adding the single quote around the word 'installation' in that case + the instructions given to them by the TT Coordination.
Nobody has EVER mistaken btw about the word being translated or not... So, if there is really a need for a change please follow my suggestions.
:-1: for the PR as it is now.

avatar javigomez
javigomez - comment - 29 Jul 2015

There should be somewhere a standard for contextualising a translating sting. I see that transifex uses the preceding line as comment. I see that Crowdin also has context and a context-screenshot but not sure what is the standard to pass it:

capture 2015-07-03 at 13 21 24

I think is worth that we check how to do this contextualising texts. But I think that there should be one optional per string. Once having that defined standard we can use it in com_localise.

avatar infograf768
infograf768 - comment - 29 Jul 2015

@javigomez
The commented lines display in com_localise if they have no empty line before and after.

screen shot 2015-07-29 at 13 27 01

But adding now comments all over the place in the ini files will add to the confusion created for TTs and force them to redo even more today than they already have to do after this series of so-called en-GB "improvements".

avatar Bakual
Bakual - comment - 29 Jul 2015

I prefer to have them before each line concerned. Reason is that there may be tools beside com_localise which show this comments, and usually Translation tools show the strings only one by one, which would only show the comment for the first string and for the others it would be invisible.

For com_localise it isn't really an issue. It's only six comments. If they generate confusion (which I doubt), maybe com_localise could be updated to show the comments in a less disturbing way then.

But adding now comments all over the place in the ini files will add to the confusion created for TTs and force them to redo even more today than they already have to do after this series of so-called en-GB "improvements".

I would be glad if you could stop complaining about those PRs in public and keep the comments on topic.

avatar Bakual
Bakual - comment - 29 Jul 2015

I see that transifex uses the preceding line as comment.

Does it? Doesn't seem to do it for my extension. But maybe I formatted them wrong.

avatar brianteeman
brianteeman - comment - 29 Jul 2015

@infograf768 there is no need for the consistent attacks for improving the language used in Joomla.

avatar Bakual Bakual - change - 29 Jul 2015
Milestone Added:
avatar Bakual Bakual - reference | d7045d0 - 29 Jul 15
avatar Bakual Bakual - merge - 29 Jul 2015
avatar Bakual Bakual - close - 29 Jul 2015
avatar Bakual Bakual - change - 29 Jul 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-07-29 12:27:56
Closed_By Bakual
avatar brianteeman brianteeman - head_ref_deleted - 29 Jul 2015
avatar infograf768
infograf768 - comment - 29 Jul 2015

If they generate confusion (which I doubt), maybe com_localise could be updated to show the comments in a less disturbing way then.

The point is not creating confusion in com_localise. The point is adding this type of comments everywhere in the ini files, thus forcing modifications of all ini files.
As I said, adding simple quotes around 'installation' when used as folder name is fine and all can be explained to TTs.

avatar Bakual
Bakual - comment - 29 Jul 2015

The point is adding this type of comments everywhere in the ini files

We're not doing that.

As I said, adding simple quotes around 'installation' when used as folder name is fine and all can be explained to TTs.

Please do a PR toadd those, but leave the comments there. :smile:

Add a Comment

Login with GitHub to post a comment