? Success

User tests: Successful: Unsuccessful:

avatar pagchen
pagchen
28 Jul 2015

Unlock Button not showing if user just have core.manage rights (and not core.admin rights).
So I change the test on core.admin to only influence the Options button and not the Unlock Button.

avatar pagchen pagchen - open - 28 Jul 2015
avatar pagchen pagchen - change - 28 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2015
Labels Added: ?
avatar stiplady
stiplady - comment - 28 Jul 2015

@pagchen White space change from 2 to 3 tabs for no apparent reason?

avatar pagchen
pagchen - comment - 29 Jul 2015

I extracted the button from the if statement.

avatar pagchen
pagchen - comment - 29 Jul 2015

In the process I did put an extra set of tabs, I removed them.

avatar Bakual
Bakual - comment - 29 Jul 2015

Can you please change the title of this PR to something representing what you propose? "Update view.html.php" is a bit to generic :smile:

avatar photodude
photodude - comment - 29 Jul 2015

I would suggest a PR tile like "correct Unlock Button management rights"

avatar Bakual Bakual - change - 29 Jul 2015
Title
Update view.html.php
Correct "Unlock" Button ACL permissions
avatar Bakual
Bakual - comment - 29 Jul 2015

Changed it myself.

avatar pagchen
pagchen - comment - 29 Jul 2015

Yes it is a better title. Thanks

avatar zero-24 zero-24 - change - 31 Jul 2015
Category ACL Administration UI/UX
avatar zero-24 zero-24 - change - 31 Jul 2015
Easy No Yes
avatar seagul30 seagul30 - test_item - 24 Oct 2015 - Tested successfully
avatar seagul30
seagul30 - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on b0d9b7f

successfully tested.

Here are some test instructions:

Add User (i.e. Manager rights)
Change User Rights for Manager Group "Global Checkin" to "Access Administration Interface" --> Allowed
Login in Backend
Check Menu "System" - "Global Checkin" --> Button "Checkin" (top left) is missing
Apply patch
Button is showing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7575.

avatar si-wi si-wi - test_item - 24 Oct 2015 - Tested successfully
avatar si-wi
si-wi - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on b0d9b7f

tested successfully according description of seagul30


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7575.

avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 24 Oct 2015

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7575.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 25 Oct 2015
Milestone Added:
avatar rdeutz rdeutz - change - 25 Oct 2015
Milestone Removed:
avatar rdeutz
rdeutz - comment - 25 Oct 2015

I think it is a change in the behauviour of the cms so 3.5

avatar roland-d
roland-d - comment - 25 Oct 2015

Thanks everybody. Merged into 3.5-dev with commit de30a73

avatar roland-d roland-d - change - 25 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-25 16:16:52
Closed_By roland-d
avatar roland-d roland-d - close - 25 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 25 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment