? ? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
26 Jul 2015

B/C Break

When integrating the Framework Application package, we removed the constructor from JApplicationBase to just use the parent Joomla\Application\AbstractApplication constructor. However, the Framework class doesn't allow the CMS's JInput object to be injected since it doesn't extend Joomla\Input\Input. So for anyone who was directly extending JApplicationBase with a custom application class and was injecting a JInput object, this was broken. I've probably got better odds of winning the lotto than that having actually happened, and it would never be noticed because JApplicationWeb and JApplicationCli never call the parent constructors to set the data that would have made this noticeable. If it weren't for me playing with tests, nobody would've known or cared.

JApplicationBaseTest Refactoring

This splits up the tests into more isolated test methods to properly test a single method or behavior per test. Also it uses more mocking of objects than before and the actual application API, cutting some of the dependency on using Reflection to inject things and leaves little dependency on calling either JFactory or JEventDispatcher except where explicitly intended to do so.

avatar mbabker mbabker - open - 26 Jul 2015
avatar mbabker mbabker - change - 26 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2015
Labels Added: ?
avatar mbabker mbabker - change - 26 Jul 2015
Labels Added: ?
avatar wilsonge wilsonge - reference | 1548eac - 26 Jul 15
avatar wilsonge wilsonge - merge - 26 Jul 2015
avatar wilsonge wilsonge - close - 26 Jul 2015
avatar wilsonge wilsonge - change - 26 Jul 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-07-26 23:13:57
Closed_By wilsonge
avatar wilsonge wilsonge - close - 26 Jul 2015
avatar mbabker mbabker - head_ref_deleted - 26 Jul 2015
avatar zero-24 zero-24 - change - 27 Jul 2015
Milestone Added:

Add a Comment

Login with GitHub to post a comment