[#7541] - Adding maxlength parameter to version_note field
- Closed
- 10 Aug 2015
- Medium
- Build: staging
- Easy Test
- # 7541
- Diff
- Bakual:FixMaxLength
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Issue
As explained in #7539 the version note will be truncated without notice if it is longer than 255 characters. That is because the database field is no bigger. See https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L1724
Solution
Add the HTML maxlength attribute so the user isn't able to enter more than 255 characters into the version note field
Testing
- Add a long string (more than 255 characters) into the version note field in any of the forms supporting it. Eg article, banner, contact. Check after saving and see that the string was truncated. You can use this string:
abcdefghijklmnopqrstuvwxyz1abcdefghijklmnopqrstuvwxyz2abcdefghijklmnopqrstuvwxyz3abcdefghijklmnopqrstuvwxyz4abcdefghijklmnopqrstuvwxyz5abcdefghijklmnopqrstuvwxyz6abcdefghijklmnopqrstuvwxyz7abcdefghijklmnopqrstuvwxyz8abcdefghijklmnopqrstuvwxyz9abcdefghijklmnopqrstuvwxyz10
- Apply patch and try to enter the string again. See that it is truncated before saving already. You will not be able to paste the full string.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
True. I was just looking for the version_note ones. But those have the same limit in the database, so adding it there would make sense.
Same also for categories and tags.
For the module it was currently already limited to 100 characters. I tracked it back to 2010 when the note was added. No clue why it was set to 100 when the database allows for 255. I changed it to 255 now.
Test successful. The note field text gets truncated when pasted.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7541.
| Category | ⇒ | Administration UI/UX |
| Easy | No | ⇒ | Yes |
| Status | Pending | ⇒ | Ready to Commit |
Works as expected now 
Thanks. --> RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7541.
| Labels |
Added:
?
|
||
Kubik-Rubik
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-10 18:35:21 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
I guess the same should be applied to the Note field in Menus and Modules?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7541.