[#7535] - contact list acl fix
- Closed
- 24 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 7535
- Diff
- brianteeman:contactlistacl
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Contact list displays trashed items - this PR fixes it
Trashed
Create multiple articles and contacts.
Create two menu items for "Articles » Category List" and "Contacts » List Contacts in a Category"
Trash one article and one contact
Check the menus - the trashed items do not appear
Login to the frontend as admin (or anyone with Special access)
Check the article menu - the trashed article does not appear
Check the contact menu - the trashed contact does appear
Unpublished
Create multiple articles and contacts.
Create two menu items for "Articles » Category List" and "Contacts » List Contacts in a Category"
Unpublish one article and one contact
Check the menus - the unpublished items do not appear
Login to the frontend as admin (or anyone with Special access)
Check the article menu - the unpublished article does appear with a flag saying unpublished
Check the contact menu - the unpublished contact does appear with a flag saying unpublished
Before
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | ACL |
| Rel_Number | 0 | ⇒ | 7534 |
| Relation Type | ⇒ | Pull Request for | |
| Easy | No | ⇒ | Yes |
| Rel_Number | 7534 | ⇒ | 7533 |
PR works as intended.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7535.
| Status | Pending | ⇒ | Ready to Commit |
Setting RTC - thanks for testing
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7535.
| Labels |
Added:
?
|
||
There is a small issue with the code where you set the state.
You set it as an array, but that will not do anything because the code will only act on the state if it is numeric, an array is ignored as an invalid state.
That's probably because you copied it from ContentModelCategory, that one in the end uses ContentModelArticles which supports an array in the state.
You can just remove the lines which set the state (286-289). It will work exactly the same.
| Status | Ready to Commit | ⇒ | Pending |
| Labels |
Removed:
?
|
||
Just checking
Done and done the same in the newsfeeds PR
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-24 07:59:50 |
| Closed_By | ⇒ | brianteeman |
All good now, thanks!
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
test good