[#7522] - [codestyle] Fixed casing in function/method names
- Closed
- 22 Jul 2015
- Medium
- Build: staging
- # 7522
- Diff
- nonumber:syntax.casing
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is a larger one and could use some thorough looking over and testing.
Also please check that I haven't changed files from external packages.
PS: The coding Standards doc doesn't specifically state that "traditionally uppercase acronyms (such as XML, HTML)" should also be camelcased in function/method names.
http://joomla.github.io/coding-standards/?coding-standards/chapters/php.md
But it does seem to make the most sense.
If it is also a rule that covers function/method names, it would be good to state that more clearly in the docs.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
Thanks for the feedback.
Fixed the issues.
And will create a PR towards joomla-framework too.
And will create a PR towards joomla-framework too.
Can you revert the changes done in the vendor folder files?
Otherwise I can do before merging myself.
done. :)
brianteeman
- | Category | ⇒ | Code style |
Perfect, thanks!
zero-24
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-22 19:29:08 |
| Closed_By | ⇒ | Bakual |
For the PR to joomla-framework, see:
joomla/joomla-framework#377
| Labels |
Added:
?
|
||
Looks good besides the things I commented inline.