? Success

User tests: Successful: Unsuccessful:

avatar nonumber
nonumber
22 Jul 2015

Not sure whether to touch FOF files...

avatar nonumber nonumber - open - 22 Jul 2015
avatar nonumber nonumber - change - 22 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jul 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 22 Jul 2015

These should be passed upstream directly to fof - we dont touch external
libraries

On 22 July 2015 at 12:01, Peter van Westen notifications@github.com wrote:

Not sure whether to touch FOF files...

You can view, comment on, or merge this pull request online at:

#7519
Commit Summary

  • Fixed casing in class names

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#7519.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar nonumber nonumber - change - 22 Jul 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-07-22 11:19:25
Closed_By nonumber
avatar nonumber
nonumber - comment - 22 Jul 2015

Ok :)

avatar nonumber nonumber - close - 22 Jul 2015
avatar nonumber nonumber - close - 22 Jul 2015
avatar nonumber
nonumber - comment - 22 Jul 2015

Closing...
@nikosdion

avatar nikosdion
nikosdion - comment - 22 Jul 2015

Class and method names in PHP are case insensitive. I don't see the point of going through all that trouble for doing a code style change in an EOL version of FOF.

avatar nonumber
nonumber - comment - 22 Jul 2015

Figured as much.

avatar nonumber nonumber - head_ref_deleted - 22 Jul 2015

Add a Comment

Login with GitHub to post a comment