[#7514] - new edit in component toolbar title
- Closed
- 24 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 7514
- Diff
- brianteeman:new-edit
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Issue
When creating or editing an item in banners, content, users and tags the toolbar title shows either New or Edit as appropriate
contact, newsfeeds, redirect and finder(filters) only had a single string in the language file so they displayed New/Edit
This PR provides consistency so that all components display either New or Edit
Testing
Go to each core component and check that a NEW item displays NEW in the toolbar title and then check that when an existing item is selected it displays EDIT in the toolbar title
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Labels |
Added:
?
?
|
||
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Administration Language & Strings UI/UX |
I am confused
I am seeing Banners: New
Is your branch upto date
On 22 July 2015 at 12:29, Marc-Antoine Thevenet notifications@github.com
wrote:
Works as describe but:
now we have different displays between the old: banners, content, users
and tags
eg. 'User Manager: Add New User' or 'Banner Manager: New Banner'and the new ones: contact, newsfeeds, redirect and finder(filters)
eg. 'News Feeds: New' (IMHO this way is the best)If you need some of my "time" to help getting: 'Banner Manager: New'
just let me know thanks!
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/7514
http://issues.joomla.org/tracker/joomla-cms/7514.—
Reply to this email directly or view it on GitHub
#7514 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Sorry... My fault,
everything is ok - Success
(note to self: never test a patch before 7am and coffee #3)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7514.
PR works as intended. Displays are correct for NEW and EDIT.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7514.
That one is useful...
| Status | Pending | ⇒ | Ready to Commit |
Thanks for testing = set RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7514.
| Labels |
Added:
?
|
||
Bakual
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-24 13:49:47 |
| Closed_By | ⇒ | Bakual |
zero-24
- | Labels |
Removed:
?
|
||
Works as described but:
now we have different displays between the old: banners, content, users and tags
eg. 'User Manager: Add New User' or 'Banner Manager: New Banner'
and the new ones: contact, newsfeeds, redirect and finder(filters)
eg. 'News Feeds: New' (IMHO this way is the best)
If you need some of my "time" to help getting: 'Banner Manager: New'
just let me know thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7514.