[#7453] - display max input vars
- Closed
- 29 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 7453
- Diff
- brianteeman:maxvar
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Since php 5.3.9 there is a php setting for the number of max_inut_vars with a default value of 1000
This pr just adds a test to display the value in com_admin&view=sysinfo
Knowing the value is quite important now especially on sites with a large number of menus, usergroups or modules as if the value for max_input_vars is not big enough then saving will fail silently or will be truncated.
(Hopefully I will also be able to provide a plugin to test the value and see if it is high enough for the users site and display a warning message)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
There are good security reasons for having the max_input_vars set at 1000
by default in PHP so you would not want to blindly increase it if there is
no need to do so.
The main case where it becomes an issue is if you have a total of more than
1000 modules, menu items and usergroups. So it is only something we should
be warning users about if they are close to the limit or have reached the
limit.
So no its not suitable for a pre-installation check or a postinstall message
On 17 July 2015 at 10:36, zero-24 notifications@github.com wrote:
@brianteeman https://github.com/brianteeman
(Hopefully I will also be able to provide a plugin to test the value and
see if it is high enough for the users site and display a warning message)postinstall message?
Should we check this also on the installation? (maybe only as "warning")—
Reply to this email directly or view it on GitHub
#7453 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Plugin coming soon as well.
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Administration |
Workend
I have tested this item 
successfully on 965d632
works
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7453.
I have tested this item successfully on 965d632
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7453.
@brianteeman can you rebase this on latest staging, there is a conflict most probably form the file administrator/language/en-GB/en-GB.com_admin.ini
I could if I knew how to but I don't. Each time I try it fails
On 24 October 2015 at 15:49, Dimitris Grammatiko notifications@github.com
wrote:
@brianteeman https://github.com/brianteeman can you rebase this on
latest staging, there is a conflict most probably form the file
administrator/language/en-GB/en-GB.com_admin.ini—
Reply to this email directly or view it on GitHub
#7453 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman please try
git pull origin maxvar
git pull upstream staging
git commit -am 'fix merge conflicts'
git push origin maxvar
Strange that when it comes to some peoples PR the committer is happy
resolve merge conflicts
I;ve moved on. Happy to just close it
On 24 October 2015 at 15:58, zero-24 notifications@github.com wrote:
@brianteeman https://github.com/brianteeman please try
git pull origin maxvar
git pull upstream staging
git commit -am 'fix merge conflicts'
git push origin maxvar—
Reply to this email directly or view it on GitHub
#7453 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Sorry I don't understand what you mean? Did it work or not?
Closed
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-29 00:30:43 |
| Closed_By | ⇒ | brianteeman |
roland-d
-
@brianteeman
postinstall message?
Should we check this also on the installation? (maybe only as "warning")