George, in one of my extensions when i'm using addStyleDeclaration i'm
using \n also such as..
addStyleDecaration("body{\n;color: #123;\n}\n"); do those need to be
PHP_EOL also?
Bear
On 7/12/2015 18:18, George Wilson wrote:

This function calls a JLayout which therefore uses Platform Specific
line endings. Therefore we need to use |PHP_EOL| instead of |\n| in
this scenario for unit tests to pass on windows

To test you can run unit tests on windows. Some will still fail - but
the ones in |JHtmlBootstrap| will now pass. You can also observe that
travis continue's to pass

---

    You can view, comment on, or merge this pull request online at:

#7424

    Commit Summary

• Fix JHtml::bootstrap unit tests on windows

  File Changes
  

• M tests/unit/suites/libraries/cms/html/JHtmlBootstrapTest.php
  https://github.com/joomla/joomla-cms/pull/7424/files#diff-0 (22)

  Patch Links:
  

• https://github.com/joomla/joomla-cms/pull/7424.patch

• https://github.com/joomla/joomla-cms/pull/7424.diff

—
Reply to this email directly or view it on GitHub
#7424.

No virus found in this message.
Checked by AVG - www.avg.com http://www.avg.com
Version: 2015.0.6081 / Virus Database: 4392/10217 - Release Date: 07/12/15

This is just for unit tests. If you're echoing out onto the page your fine

great, ty.
Bear
On 7/13/2015 08:44, George Wilson wrote:

This is just for unit tests. If you're echoing out onto the page your fine

—
Reply to this email directly or view it on GitHub
#7424 (comment).

No virus found in this message.
Checked by AVG - www.avg.com http://www.avg.com
Version: 2015.0.6081 / Virus Database: 4392/10221 - Release Date: 07/13/15