? Success

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
12 Jul 2015

JToolbarHelper::title allow to add HTML markup for toolbar, however it also add the HTML for browser title.
This pull fix it.

test
into Isis template file index.php add next: JToolbarHelper::title('<b>Test</b>');
and check the browser title
actual result
Site Name - Administration - <b>Test</b>
expected
Site Name - Administration - Test

avatar Fedik Fedik - open - 12 Jul 2015
avatar Fedik Fedik - change - 12 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jul 2015
Labels Added: ?
avatar Fedik
Fedik - comment - 12 Jul 2015

hm, or maybe better do it globally in JDocumentRendererHead::fetchHead ?

avatar Bakual
Bakual - comment - 12 Jul 2015

hm, or maybe better do it globally in JDocumentRendererHead::fetchHead ?

It's fine where you did it.

avatar zero-24 zero-24 - change - 12 Jul 2015
Category Templates (admin)
avatar zero-24 zero-24 - change - 12 Jul 2015
Easy No Yes
avatar peterlose peterlose - test_item - 14 Jul 2015 - Tested successfully
avatar peterlose
peterlose - comment - 14 Jul 2015

Tested. All good!

avatar jwaisner
jwaisner - comment - 15 Jul 2015

@test

PR works as intended.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7422.

avatar jwaisner jwaisner - test_item - 15 Jul 2015 - Tested successfully
avatar zero-24 zero-24 - change - 15 Jul 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 15 Jul 2015

RTC Thanks :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7422.

avatar zero-24 zero-24 - change - 15 Jul 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 15 Jul 2015
Milestone Added:
avatar Kubik-Rubik Kubik-Rubik - reference | 714c162 - 15 Jul 15
avatar zero-24 zero-24 - close - 15 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - change - 15 Jul 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-07-15 13:04:16
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 15 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - merge - 15 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - close - 15 Jul 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 15 Jul 2015

Thank you @Fedik! Merged.

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment