? ? Success
Referenced as Related to: # 7673

User tests: Successful: Unsuccessful:

avatar shur
shur
11 Jul 2015

This PR just add missed declaration remove declaration of the module xml file.

avatar shur shur - open - 11 Jul 2015
avatar shur shur - change - 11 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 11 Jul 2015

I'm not sure. As far i know we don't need to add this via xml as we do it automatic?

avatar shur
shur - comment - 11 Jul 2015

I was guided by how it's done in other modules.

avatar zero-24 zero-24 - change - 12 Jul 2015
Category Code style
avatar shur
shur - comment - 8 Aug 2015

Most of xml files of modules contain this line.
So we must take a decision - if this line should be present, then it must be present in all modules.
If this line is unnecessary, then we must remove it from all modules.

avatar mbabker
mbabker - comment - 8 Aug 2015

It is not required to list the XML as part of the manifest; it is always copied over. As long as its consistent, the manifests can be updated either way to include or exclude the XML file.

avatar shur
shur - comment - 8 Aug 2015

So what is your suggestion?
Right now it's not consistent - some module xmls have this line some don't. It's confusing for anyone who studies core Joomla modules as a base for his own module.

avatar mbabker
mbabker - comment - 8 Aug 2015

It's not a requirement and I don't have it in any of my own extension manifests, so I would say remove it.

avatar shur shur - change - 8 Aug 2015
Title
Skipped declaration of xml file in the mod_users_latest
Remove declaration of xml files in modules
avatar shur shur - change - 8 Aug 2015
Title
Skipped declaration of xml file in the mod_users_latest
Remove declaration of xml files in modules
avatar shur
shur - comment - 8 Aug 2015

Perhaps, I agree with you.
I made all modules xmls be consistent in this case.

avatar Bakual
Bakual - comment - 8 Aug 2015

Merged into staging with eabb506.
Thanks!

avatar Bakual Bakual - change - 8 Aug 2015
Milestone Added:
avatar Bakual Bakual - change - 8 Aug 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-08-08 21:04:58
Closed_By Bakual
avatar Bakual Bakual - close - 8 Aug 2015
avatar zero-24 zero-24 - close - 8 Aug 2015
avatar Bakual Bakual - close - 8 Aug 2015
avatar zero-24 zero-24 - change - 10 Aug 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment