[#7403] - Refactoring onInit method - reCAPTCHA plugin
- Closed
- 24 Oct 2015
- Medium
- Build: staging
- # 7403
- Diff
- Kubik-Rubik:imp-recaptcha-remove-mootools
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR is based on #6218 but is completely revised. I've refactored the function onInit and changed one default value (light theme instead of dark theme for version 2.0).
The main reason for the refactoring is to get rid of the loading of Mootools which is not required.
How to test?
- Go to "Extensions" - "Plugins" - "CAPTCHA - reCAPTCHA"
- Enter your Public and Private key (get it here: https://www.google.com/recaptcha/intro/index.html)
- Activate the plugin
- Set the reCAPTCHA plugin as default captcha in the global configuration
- Go to a form in the frontend (e.g. registration form - add index.php?option=com_users&view=registration to the URL) and check whether the capchta is loaded properly.
Please test both versions (1.0 and 2.0)!
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
I've never seen the dark one anywhere... Google also uses the light theme everywhere. But of course it's not a must, I can set it back to the dark (even though I don't like it ;-) ).
Was just wondering thats all
@test unsuccesfully tested with ReCaptcha 1.0 and 2.0.
- ReCaptcha plugin enabled and added site/secret keys.
- Global Configuration > Default Captcha > ReCaptcha enabled.
- Users > User Manager > Options > Users Manager > Captcha > Use Default / Captcha.
- tested with template Beez3.
ReCaptcha worked on:
Single Contact
Username Reminder Request
Password Reset
ReCaptcha not worked on:
Login Form
Registration Form
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7403.
| Category | ⇒ | Plugins |
@genesisfan This refactoring of the function is independent of the form where the captcha should be loaded. If it's loaded in one form, it should be loaded in every other form too. So, how did you test it?
@test I've retested your PR successfully.
In the first test the registration form was not shown. Due the fact I was forgotten to enable user registration.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7403.
| Status | Pending | ⇒ | Ready to Commit |
Thanks @Kubik-Rubik just tested successful with version 1.0 and 2.0.
Together with the successful test by @genesisfan I'm goint ot RTC this. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7403.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-24 07:05:01 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Why have you changed the default theme?