Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7398] - [CODE STYLE] Simple code style improvement

? ? Success

User tests: Successful: Unsuccessful:

avatar nonumber
nonumber
9 Jul 2015

Removed redundant nesting by using early return.

avatar nonumber nonumber - open - 9 Jul 2015
avatar nonumber nonumber - change - 9 Jul 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jul 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 10 Jul 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 10 Jul 2015

Can you make Mr. Travis happy? @nonumber ;)

FILE: /home/travis/build/joomla/joomla-cms/libraries/joomla/language/text.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 259 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------
avatar zero-24 zero-24 - change - 10 Jul 2015
Category ⇒ Code style
avatar nonumber
nonumber - comment - 10 Jul 2015

Done :)

PS: would be cool if trailing whitespace would be fixed automagically. Time to upgrade to CodeSniffer 2?

avatar zero-24
zero-24 - comment - 10 Jul 2015

PS: would be cool if trailing whitespace would be fixed automagically. Time to upgrade to CodeSniffer 2?

The work has been startet but I'm not sure what hold the change or is needed ;) See: https://github.com/joomla/coding-standards/pulls

avatar Kubik-Rubik
Kubik-Rubik - comment - 10 Jul 2015

Thank you @nonumber! Merged.

avatar zero-24 zero-24 - close - 10 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - change - 10 Jul 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-07-10 08:28:16
Closed_By ⇒ Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 10 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - close - 10 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - reference | a464138 - 10 Jul 15
avatar Kubik-Rubik Kubik-Rubik - merge - 10 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - close - 10 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - change - 10 Jul 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 10 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment