Pending

User tests: Successful: Unsuccessful:

avatar rmcdaniel rmcdaniel - open - 26 Feb 2013
avatar rmcdaniel
rmcdaniel - comment - 27 Feb 2013

I've just pushed a slightly better proposed fix.

avatar infograf768
infograf768 - comment - 28 Feb 2013

Please correct code style

if ($category == false) {

  • return JError::raiseError(404, JText::('JGLOBALCATEGORY_NOT_FOUND'));
  • }

shoudl be

if ($category == false)

  • {
  • return JError::raiseError(404, JText::('JGLOBALCATEGORY_NOT_FOUND'));
  • }

in 2 cases

avatar rmcdaniel
rmcdaniel - comment - 28 Feb 2013

Fixed it. Sorry about that. I didn't notice TextWrangler did that.

avatar infograf768
infograf768 - comment - 28 Feb 2013

suggestion: why not extend this patch to the other core components?

avatar sybrek
sybrek - comment - 28 Feb 2013

@rmcdaniel it's the same thing

$foo = true;
if($foo){}

is equal to

if($foo = true){}

@infograf768 +1

avatar rmcdaniel
rmcdaniel - comment - 28 Feb 2013

@sybrek Sorry, I glanced at it and I didn't see the assignment.

@infograf768 I wasn't aware there was an issue in any other components. I'll take a look.

avatar rmcdaniel
rmcdaniel - comment - 4 Mar 2013

I didn't see this issue popping up anywhere else.

avatar infograf768 infograf768 - close - 13 Jun 2013
avatar infograf768
infograf768 - comment - 13 Jun 2013

I committed this to both 2.5 and master.
@rmcdaniel
If I do not mistake, I see a similar code for contacts, newsfeeds, weblinks in both 2.5 and master.
Thank you for looking into it and provide a PR per version.

avatar AshanFernando AshanFernando - reference | - 7 Jul 13
avatar garyamort garyamort - reference | - 2 Dec 13

Add a Comment

Login with GitHub to post a comment