User tests: Successful: Unsuccessful:
Please correct code style
if ($category == false) {
shoudl be
if ($category == false)
in 2 cases
Fixed it. Sorry about that. I didn't notice TextWrangler did that.
suggestion: why not extend this patch to the other core components?
@rmcdaniel it's the same thing
$foo = true;
if($foo){}
is equal to
if($foo = true){}
@infograf768 +1
@sybrek Sorry, I glanced at it and I didn't see the assignment.
@infograf768 I wasn't aware there was an issue in any other components. I'll take a look.
I didn't see this issue popping up anywhere else.
I committed this to both 2.5 and master.
@rmcdaniel
If I do not mistake, I see a similar code for contacts, newsfeeds, weblinks in both 2.5 and master.
Thank you for looking into it and provide a PR per version.
I've just pushed a slightly better proposed fix.