[#7384] - Various cosmetic fixes regarding alignment for Extension, Module, Plugin, Language, Template Managers
- Closed
- 11 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 7384
- Diff
- manojLondhe:staging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is a PR for fixing alignment issues for list views from com_installer component.
Manage view - before
Manage view - after
Update view - before
Update view - after
Discover view - before
Discover view - after
Update sites view - before
Update sites view - after
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
There is inconsistency across other manager views as well.
- Module and plugin manager have - status and ID columns center aligned, rest left aligned
- Template Manager: Styles has Default, ID, Location, Template columns center aligned
- Template Manager: Styles have - Location, Version, Date, Author center aligned
Similar story for Language Manger as well!
Yes and they should be fixed ;)
On 9 July 2015 at 10:47, Manoj L notifications@github.com wrote:
There is inconsistency across other manager views as well.
- Module and plugin manager have - status and ID columns center aligned, rest left aligned
- Template Manager: Styles has Default, ID, Location, Template columns center aligned
- Template Manager: Styles have - Location, Version, Date, Author center aligned
Similar story for Language Manger as well!
—
Reply to this email directly or view it on GitHub
#7384 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
OK, will fix those too keeping only - Status, Default and Numeric/ID columns center aligned!
See #6076 for some previous discussion on this
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7384.
Sure!
Just noticed com_users using class="left" for table headings, but that class does not exist in backend default template CSS, neither does "right".
Using "right" for numerics makes sense[#6076] but that class does not exist in template, so should I stick with "center"?
I would go with
#6076 (comment)
On 9 July 2015 at 11:09, Manoj L notifications@github.com wrote:
Sure!
Just noticed com_users using class="left" for table headings, but that
class does not exist in backend default template CSS, neither does "right".
Using "right" for numerics makes sense[#6076
#6076] but that class does
not exist in template, so should I stick with "center"?—
Reply to this email directly or view it on GitHub
#7384 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
zero-24
- | Category | ⇒ | Language & Strings UI/UX |
| Easy | No | ⇒ | Yes |
OK, but what about "right", "left" classes that don't exists?
My understanding from the comments in that other thread is that left is the
default for LTR and right is the default for RTL so no class is needed
| Title |
|
||||||
Pushed changes for - Extension, Module, Plugin, Language, Template Managers
- Extension Manager
- Module Manager
- Plugin Manager
- Template Manager
- Language Manager
- Module Manager
-
Installer
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7384.
| Category | Language & Strings UI/UX | ⇒ | Language & Strings Templates (admin) UI/UX |
@test succesfully tested with FF38.0.5. Well done @manojLondhe looks much better.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7384.
Tested succesfully.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7384.
roland-d
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-11 14:58:09 |
| Closed_By | ⇒ | roland-d |
@genesisfan Thanks!
Thanks guys :)
| Milestone |
Added: |
||
I agree with the movement of the status column
BUT
To be consistent with the other manager views the columns should be left
aligned (I think status and numeric columns are the only ones that are
currently center aligned). It IS a bug that the columns are currently
centered so instead of making the title center aligned please make the
heading left aligned instead
On 9 July 2015 at 10:30, Manoj L notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/