[#7382] - Layout codestyle improvements
- Fixed in Code Base
- 14 Aug 2016
- Medium
- Build: staging
- # 7382
- Diff
- n9iels:layout-codestyle
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR improve the codestyle of the files in the /layouts folder.
I followed the Joomla! coding standards, and made some additions that seems logic for myself to make the code better to read.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
Thanks. I have fond two more sorry ;)
| Category | ⇒ | Code style |
can someone else also toke a look at this pr so it can be merged?
| Labels |
Added:
?
|
||
Hi, I tested this PR and it is working. The style changes seem consistent now. 
I have tested this item successfully on 9194e23
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7382.
This PR has received new commits.
CC: @RonakParmar
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7382.
roland-d
- | Status | Pending | ⇒ | Information Required |
This PR has received new commits.
CC: @polakluk, @RonakParmar
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7382.
This PR has received new commits.
CC: @polakluk, @RonakParmar
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7382.
This PR has received new commits.
CC: @polakluk, @RonakParmar
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7382.
I found "No newline at end of file" in "layouts/joomla/content/options_default.php" file.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7382.
@RonakParmar Travis says there are no problems with the codestyle
Please check " layouts/joomla/content/options_default.php" file difference at https://github.com/joomla/joomla-cms/pull/7382/files
You can see "No newline at end of file".
| Status | Information Required | ⇒ | Pending |
@n9iels if you can fix that to make @RonakParmar happy I will set this RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7382.
| Category | Code style | ⇒ | Layout Code style |
| Status | Pending | ⇒ | Ready to Commit |
RTC doesn't need new tests for that last change
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7382.
| Labels |
Added:
?
|
||
@n9iels sorry but travis is still not happy.
https://travis-ci.org/joomla/joomla-cms/jobs/149221540
FILE: ...mla/joomla-cms/layouts/joomla/content/blog_style_default_item_title.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
43 | ERROR | Tabs must be used to indent lines; spaces are not allowed
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-14 10:55:51 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
@zero-24 thanks!