Feeling Lucky
?
[#7373] - Remove addLog function that doesn't exist
- Closed
- 9 Jul 2015
- Medium
- Build: staging
- # 7373
- Diff
- wilsonge:logging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is used in various parts of the Database importer classes (e.g. https://github.com/wilsonge/joomla-cms/blob/logging/libraries/joomla/database/importer.php#L217) but isn't actually defined. This just adds the method and proxies it to JLog
Note this class is not used in the CMS and so probably needs a code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Milestone |
Added: |
||
| Category | ⇒ | Libraries |
wilsonge
- comment
- 8 Jul 2015
As we are logging them in a separate category now quite possibly...
I'll await a decision from leadership on how to proceed :P
rdeutz
- comment
- 8 Jul 2015
If it is logged somewhere then I would remove the call
wilsonge
- comment
- 8 Jul 2015
Removed
Bakual
- comment
- 8 Jul 2015
| Title |
|
||||||
wilsonge
- comment
- 8 Jul 2015
Is this mergable?
Bakual
- comment
- 9 Jul 2015
Yes
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-09 06:22:52 |
| Closed_By | ⇒ | wilsonge |
I wonder if it is even needed. I learned recently that the driver itself already logs failed database queries. Maybe we can just remove the calls to addLog instead.