[#7370] - Update en-GB.com_banners.ini
- Closed
- 8 Jul 2015
- Medium
- Build: staging
- # 7370
- Diff
- aaleksanyants:patch-6
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Replaced wrong word (probably taken from another file mechanically)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Ready to Commit |
| Category | ⇒ | Language & Strings |
zero-24
- | Labels |
Added:
?
|
||
| Milestone |
Added: |
||
Thank you @aaleksanyants! Merged.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-08 11:46:35 |
| Closed_By | ⇒ | Kubik-Rubik |
Why the status is "Closed with unmerged commits"?
It's the STUPID way it has been committed without any comment
On 8 Jul 2015 2:56 pm, "Andrey Aleksanyants" notifications@github.com
wrote:
Why the status is "Closed with unmerged commits"?
—
Reply to this email directly or view it on GitHub
#7370 (comment).
@brianteeman Sorry, Brian, what do you mean with your statement?
That you didn't post anything to show that it had been committed.
Just saying closed with a ref is NOT obvious
On 8 Jul 2015 3:01 pm, "Viktor Vogel" notifications@github.com wrote:
@brianteeman https://github.com/brianteeman Sorry, Brian, what do you
mean with your statement?—
Reply to this email directly or view it on GitHub
#7370 (comment).
I wrote "Thank you @aaleksanyants! Merged." and I do not close the PRs manually but GitHub does it automatically because we add Fixes ID to the commit before we merge it (in the console)...
| Labels |
Removed:
?
|
||
Good find. Thanks.