User tests: Successful: Unsuccessful:
Fixed invalid HTML tags
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
Category | ⇒ | Language & Strings |
Status | Pending | ⇒ | Ready to Commit |
Rel_Number | 0 | ⇒ | 7358 |
Relation Type | ⇒ | Pull Request for |
Labels |
Added:
?
|
Should we not use the …
html entity for the ellipsis?
https://github.com/joomla/user-interface-text/blob/master/punctuation.md#ellipsis
On 7 July 2015 at 15:38, George Wilson notifications@github.com wrote:
Should we not use the … html entity for the ellipsis?
—
Reply to this email directly or view it on GitHub
#7362 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
OK well what is in this PR reverts the change in your link there to the ellipsis
In which case please update as per the style guide
On 7 July 2015 at 16:42, George Wilson notifications@github.com wrote:
OK well what is in this PR reverts the change in your link there to the
ellipsis—
Reply to this email directly or view it on GitHub
#7362 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Labels |
Removed:
?
|
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Pending |
@aaleksanyants you can fix this by adding a new commit to your branch. If you edit that file here: https://github.com/aaleksanyants/joomla-cms/blob/patch-3/administrator/language/en-GB/en-GB.com_config.ini and commit this this pull request gets updated
Labels |
Removed:
?
|
@aaleksanyants please try to edit file in my comment :)
go to: https://github.com/aaleksanyants/joomla-cms/blob/patch-3/administrator/language/en-GB/en-GB.com_config.ini
klick the "edit button"
change the file
commit with a message
PR gets updated ;)
But the file is already updated! please search for ** within it and you will see that there are no BOLD tags any more
@aaleksanyants
If I get it right, you should correct the use of …
and replace it by what it was before, i.e. 3 dots ...
I have replaced three dots with a single ellipsis char itself and it is displayed correctly (because all files are treat as UTF-8 files), so why should I replace it with its HTML entity or revert back to three dots?
Or do you provide HTML entities for all cedils, acutes etc when translating to French?
@aaleksanyants please see #7362 (comment)
So is it about adding spaces before and after, or about replacing a single char with three dots chars?
Your guide says "Each period should have a single space on either side. " But I could not find a single string in language files which would implement that rule. All read more strings contain a space before the first period, but none of them has spaces between periods, ie ... (replace undelines with spaces). And if we speak about adding leading and trailing spaces, they are already there …
I guess there is a mistake in that guide
Each period should have a single space on either side.
should be read as Each group of 3 periods should have a single space on either side.
Yes I am updating that part
On 9 July 2015 at 10:44, infograf768 notifications@github.com wrote:
I guess there is a mistake in that guide
Each period should have a single space on either side.
should be read as Each group of 3 periods should have a single space on
either side.—
Reply to this email directly or view it on GitHub
#7362 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@aaleksanyants
This the en-GB language, not French or else.
They have decided to NOT use the ellipsis but 3 dots instead.
You for Armenian or I for French can do anything we like
OK, I have replaced ellipse back to three dots per your request. BTW, I have checked the original version and saw that it had no leading/trailing spaces within the row...
Yes that was missed when the style guide was created. I have created another PR for some other missing spaces
I have tested this item successfully on b8ce177
Status | Pending | ⇒ | Ready to Commit |
Labels |
Labels |
Added:
?
|
Milestone |
Added: |
This PR has received new commits.
I have tested this item successfully on a69ab32
Only updated the branch to latest staging. All equal.
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 18:55:22 |
Closed_By | ⇒ | rdeutz |
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
Labels |
Removed:
?
|
Simple and correct change - setting to RTC - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7362.