? ? Pending
Pull Request for # 7358

User tests: Successful: Unsuccessful:

avatar aaleksanyants
aaleksanyants
7 Jul 2015

Fixed invalid HTML tags

avatar aaleksanyants aaleksanyants - open - 7 Jul 2015
avatar aaleksanyants aaleksanyants - change - 7 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jul 2015
Labels Added: ? ?
avatar brianteeman brianteeman - change - 7 Jul 2015
Category Language & Strings
avatar brianteeman
brianteeman - comment - 7 Jul 2015

Simple and correct change - setting to RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7362.

avatar brianteeman brianteeman - change - 7 Jul 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 7 Jul 2015
Rel_Number 0 7358
Relation Type Pull Request for
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?
avatar wilsonge
wilsonge - comment - 7 Jul 2015

Should we not use the … html entity for the ellipsis?

avatar brianteeman
brianteeman - comment - 7 Jul 2015

https://github.com/joomla/user-interface-text/blob/master/punctuation.md#ellipsis

On 7 July 2015 at 15:38, George Wilson notifications@github.com wrote:

Should we not use the … html entity for the ellipsis?


Reply to this email directly or view it on GitHub
#7362 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar wilsonge
wilsonge - comment - 7 Jul 2015

OK well what is in this PR reverts the change in your link there to the ellipsis

avatar brianteeman
brianteeman - comment - 7 Jul 2015

In which case please update as per the style guide

On 7 July 2015 at 16:42, George Wilson notifications@github.com wrote:

OK well what is in this PR reverts the change in your link there to the
ellipsis


Reply to this email directly or view it on GitHub
#7362 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar wilsonge wilsonge - change - 7 Jul 2015
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jul 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 7 Jul 2015
Status Ready to Commit Pending
avatar zero-24
zero-24 - comment - 7 Jul 2015

@aaleksanyants you can fix this by adding a new commit to your branch. If you edit that file here: https://github.com/aaleksanyants/joomla-cms/blob/patch-3/administrator/language/en-GB/en-GB.com_config.ini and commit this this pull request gets updated :smile: :+1:

avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Removed: ?
avatar aaleksanyants
aaleksanyants - comment - 8 Jul 2015

@zero-24 , when trying to do that I get the message:
There isn't anything to compare.
joomla:staging is up to date with all commits from aaleksanyants:staging. Try switching the base for your comparison.

avatar zero-24
zero-24 - comment - 8 Jul 2015

@aaleksanyants please try to edit file in my comment :)

go to: https://github.com/aaleksanyants/joomla-cms/blob/patch-3/administrator/language/en-GB/en-GB.com_config.ini
klick the "edit button"
change the file
commit with a message
PR gets updated ;)

avatar aaleksanyants
aaleksanyants - comment - 8 Jul 2015

But the file is already updated! please search for ** within it and you will see that there are no BOLD tags any more

avatar infograf768
infograf768 - comment - 8 Jul 2015

@aaleksanyants
If I get it right, you should correct the use of … and replace it by what it was before, i.e. 3 dots ...

avatar aaleksanyants
aaleksanyants - comment - 8 Jul 2015

I have replaced three dots with a single ellipsis char itself and it is displayed correctly (because all files are treat as UTF-8 files), so why should I replace it with its HTML entity or revert back to three dots?

avatar aaleksanyants
aaleksanyants - comment - 8 Jul 2015

Or do you provide HTML entities for all cedils, acutes etc when translating to French?

avatar wojsmol
wojsmol - comment - 8 Jul 2015
avatar aaleksanyants
aaleksanyants - comment - 8 Jul 2015

So is it about adding spaces before and after, or about replacing a single char with three dots chars?

avatar aaleksanyants
aaleksanyants - comment - 9 Jul 2015

Your guide says "Each period should have a single space on either side. " But I could not find a single string in language files which would implement that rule. All read more strings contain a space before the first period, but none of them has spaces between periods, ie ... (replace undelines with spaces). And if we speak about adding leading and trailing spaces, they are already there …

avatar infograf768
infograf768 - comment - 9 Jul 2015

I guess there is a mistake in that guide
Each period should have a single space on either side.
should be read as Each group of 3 periods should have a single space on either side.

avatar brianteeman
brianteeman - comment - 9 Jul 2015

Yes I am updating that part

On 9 July 2015 at 10:44, infograf768 notifications@github.com wrote:

I guess there is a mistake in that guide
Each period should have a single space on either side.
should be read as Each group of 3 periods should have a single space on
either side.


Reply to this email directly or view it on GitHub
#7362 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 9 Jul 2015

@aaleksanyants
This the en-GB language, not French or else.
They have decided to NOT use the ellipsis but 3 dots instead.
You for Armenian or I for French can do anything we like :smile:

avatar aaleksanyants
aaleksanyants - comment - 9 Jul 2015

OK, I have replaced ellipse back to three dots per your request. BTW, I have checked the original version and saw that it had no leading/trailing spaces within the row...

avatar brianteeman
brianteeman - comment - 9 Jul 2015

Yes that was missed when the style guide was created. I have created another PR for some other missing spaces

avatar andrepereiradasilva andrepereiradasilva - test_item - 27 Dec 2015 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Dec 2015

I have tested this item :white_check_mark: successfully on b8ce177


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7362.

avatar brianteeman brianteeman - change - 10 Mar 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 10 Mar 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7362.

avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 10 Mar 2016
Milestone Added:
avatar joomla-cms-bot
joomla-cms-bot - comment - 10 Mar 2016

This PR has received new commits.

CC: @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7362.

avatar andrepereiradasilva andrepereiradasilva - test_item - 10 Mar 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Mar 2016

I have tested this item :white_check_mark: successfully on a69ab32

Only updated the branch to latest staging. All equal.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7362.

avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar rdeutz rdeutz - reference | c3903a7 - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 18:55:22
Closed_By rdeutz
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment