[#7360] - Update en-GB.tpl_beez3.ini
- Fixed in Code Base
- 12 Apr 2016
- Medium
- Build: staging
- # 7360
- Diff
- aaleksanyants:patch-1
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Updated template description
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Labels |
Added:
?
?
|
||
| Category | ⇒ | Language & Strings |
| Rel_Number | 0 | ⇒ | 7358 |
| Relation Type | ⇒ | Pull Request for |
yes it is :-)
Same string has to be changed in:
language/en-GB/en-GB.tpl_beez3.sys.ini
and in same files here:
templates/beez3/language/en-GB/en-GB.tpl_beez3.sys.ini
templates/beez3/language/en-GB/en-GB.tpl_beez3.ini
Thank for pointing out the appropriate files in template folder, all files have been changed
For testers, is there anything we should see different besides the strings being changed?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.
For testers, is there anything we should see different besides the strings being changed?
No ;)
If we get a ok by the en-GB WG we can move language files onky PRs to RTC ;)
I have tested this item 
successfully on 41a4704
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.
By adding the version number for joomla this fails the style guide for the use of the joomla name https://joomla.github.io/user-interface-text/?user-interface-text/joomla_name_usage.md
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.
I have tested this item successfully on 41a4704
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.
This PR has received new commits.
CC: @andrepereiradasilva, @waader
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.
I have not tested this item.
just a "!" so of course is tested ok
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.
@andrepereiradasilva Please mark on https://issues.joomla.org/tracker/joomla-cms/7360 as tested successfully.
I have tested this item successfully on 1d2ba99
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.
sorry wrong box.
I know this can hardly be automated, but for this type of changes is it really need any other tests?
Contacted Angie as the creator of the template to confirm the html5 change
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
Confirmed with Angie Setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.
| Labels |
Added:
?
|
||
This PR has received new commits.
CC: @andrepereiradasilva, @waader
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.
I have tested this item successfully on 26f2759
Only updated the branch to latest staging. All equal.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 18:54:20 |
| Closed_By | ⇒ | rdeutz |
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Labels |
Removed:
?
|
||
This changes the description from html 4 to html5
Is this template actually html5?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7360.