Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7337] - [Banners] Backport the fixes / changes from the banners repo into the CMS

? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
3 Jul 2015

For the changes see:
joomla-extensions/banners#1
joomla-extensions/banners#2
zero-24/banners#1
zero-24/banners#2
#7009
#6978
#6946

How to test

Please test be careful that com_banners and mod_banners still works as expected.

avatar zero-24 zero-24 - open - 3 Jul 2015
avatar zero-24 zero-24 - change - 3 Jul 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2015
Labels Added: ?
avatar smz
smz - comment - 4 Jul 2015

@zero-24 Sorry, I may be thick but I don't understand how we should test this:

  • Apply patch to an existing installation and test

or...

  • Apply patch, perform installation anew, and then test
avatar zero-24
zero-24 - comment - 4 Jul 2015

@smz the first one as we don't finaly remove banners this only backports the fixes. But i guess i should remove the most changes.

avatar zero-24 zero-24 - change - 4 Jul 2015
Category ⇒ Administration Front End Modules
avatar zero-24
zero-24 - comment - 5 Jul 2015

Just synced to staging and get some changes to the doc block out of this PR. Let me know if i should also remove the CS fixes.

avatar smz
smz - comment - 6 Jul 2015

Tested as far as I could and found no issue...

Tested functionalities:

  • Banners (Image type only, not custom)
  • Categories
  • Clients
  • Tracks
  • Banners versioning
  • Banners and Categories batch operations
  • Multilingual functionality
  • Untested with Postgress

The only anomaly I found is that categories language doesn't seems to have any effect: it is the Banners language that determine for which languages a particular banner is displayed...

avatar smz smz - test_item - 6 Jul 2015 - Tested successfully
avatar jwaisner
jwaisner - comment - 7 Jul 2015

@test

After applying PR, no changes to operation of com_banners and mod_banners. Test successful.

Note: Not Tested on Postgress

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7337.

avatar jwaisner jwaisner - test_item - 7 Jul 2015 - Tested successfully
avatar smz
smz - comment - 25 Jul 2015

It seems that the PLT decision to not uncouple extensions has been reverted (see: https://groups.google.com/d/msg/joomla-dev-cms/wLORxHBDSI0/iQxroGhCfBsJ): shouldn't we close this and re-open #7008 ?

avatar zero-24 zero-24 - change - 27 Jul 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 27 Jul 2015

Based on the comment by @wilsonge in the Google Group and the tests I'm RTC'ing

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7337.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 3 Aug 2015
Milestone Added:
avatar zero-24
zero-24 - comment - 9 Aug 2015

@Kubik-Rubik I have just fixed the conflicts.

avatar wilsonge
wilsonge - comment - 1 Sep 2015

We also need to fix the conflicts again please (sorry)

avatar zero-24 zero-24 - change - 2 Sep 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-09-02 07:11:02
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 2 Sep 2015
avatar joomla-cms-bot joomla-cms-bot - close - 2 Sep 2015
avatar zero-24 zero-24 - close - 2 Sep 2015
avatar joomla-cms-bot joomla-cms-bot - change - 2 Sep 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 2 Sep 2015
Milestone Removed:
avatar zero-24 zero-24 - reopen - 2 Sep 2015
avatar zero-24 zero-24 - change - 2 Sep 2015
Status Closed ⇒ New
Closed_Date 2015-09-02 07:11:01 ⇒
Closed_By zero-24 ⇒
avatar zero-24 zero-24 - change - 2 Sep 2015
Status New ⇒ Closed
avatar zero-24 zero-24 - reopen - 2 Sep 2015
avatar zero-24
zero-24 - comment - 2 Sep 2015

@wilsonge just fixed.

avatar zero-24
zero-24 - comment - 2 Sep 2015

@mbabker I have also reverted all SQL Changes.

avatar zero-24 zero-24 - change - 17 Oct 2015
Milestone Added:
avatar zero-24
zero-24 - comment - 17 Oct 2015

Maybe somone can have a look here. Nothing critical will be changed ;)

avatar dgt41 dgt41 - test_item - 24 Oct 2015 - Tested successfully
avatar dgt41
dgt41 - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on dbd6c6f

Inception mode = ON

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7337.

avatar dgt41
dgt41 - comment - 24 Oct 2015

To test this go to /administrator/index.php?option=com_banners&view=tracks click on the button export and then test if the buttons Export and cancel are closing the modal

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7337.

avatar zero-24 zero-24 - change - 24 Oct 2015
Status New ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 24 Oct 2015

Thanks :smile:

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 25 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-25 10:09:28
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 25 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 25 Oct 2015
avatar rdeutz rdeutz - reference | 25e15db - 25 Oct 15
avatar rdeutz rdeutz - merge - 25 Oct 2015
avatar rdeutz rdeutz - close - 25 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - head_ref_deleted - 25 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment