User tests: Successful: Unsuccessful:
The quickicon plugin which checks for Joomla Updates shows the message twice.
The JavaScript code which adds this message checks for a <span>
in the specific ID of that plugin output and adds the message there. This worked fine as long as there was only one <span>
there. Now we changed the icons to use the <span>
tag instead of <i>
and guess what, now there are two <span>
tags in there. You don't need to be a JavaScript guru to understand what now happens
The solution is to not target the <span>
tag itself but the specific class of that <span>
Best test with a Joomla 3.4.2 before updating to 3.4.3.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Nah, has nothing to do with browser cache.
jQuery('#plg_quickicon_joomlaupdate').find('span').html(updateString);
will update each <span>
within the tag with the attribute "id=plg_quickicon_joomlaupdate".
The HTML structure for the quickicon is like this:
<li id="plg_quickicon_joomlaupdate">
<a href="index.php?option=com_joomlaupdate">
<span class="icon-joomla"></span>
<span class="j-links-link">Unknown Joomla! ...</span>
</a>
</li>
See the two <span>
tags there?
The icon one comes from
https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/links/link.php#L21
and the content one from
https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/links/link.php#L16
must have been an earlier issue then with the same outcome but for a
different reason
On 2 July 2015 at 20:58, Thomas Hunziker notifications@github.com wrote:
Nah, has nothing to do with browser cache.
jQuery('#plg_quickicon_joomlaupdate').find('span').html(updateString);
will update each within the tag with the attribute
"id=plg_quickicon_joomlaupdate".
The HTML structure for the quickicon is like this:
Unknown Joomla! ...
See the two tags there?
The icon one comes fromhttps://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/links/link.php#L21
and the content one fromhttps://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/links/link.php#L16
—
Reply to this email directly or view it on GitHub
#7323 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Maybe, yes.
I noticed this behaviour a few days ago and deleting the cache seemed to solve the problem. Now that I logged in again, it´s obvious that the problem persists.
After applying this patch the duplicated message is gone. Logging in again, everthing is fine.
@test success! Thanks!
same issue on extensions check
Ah, I did know that I had cleared and cleared browser cache and all caches possible. Almost cleared my OS to get rid of the double message...
I do not have the issue on extension check here.
Category | ⇒ | Plugins |
Labels |
Added:
?
|
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Removed: |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-03 08:37:21 |
Closed_By | ⇒ | Bakual |
same issue on extensions check
Can you point us to the check? I'm not sure what do you find on the extensions check see: https://github.com/joomla/joomla-cms/blob/staging/media/plg_quickicon_extensionupdate/js/extensionupdatecheck.js
same issue on extensions check
If it is, then it's a different issue. Did you try with clearing the browser cache?
the same fix did the trick, so its ok now
Labels |
Removed:
?
|
I dont understand - once you clear the browser cache this issue does not
exist
On 2 July 2015 at 19:04, Thomas Hunziker notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/