? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
2 Jul 2015

Issue

The quickicon plugin which checks for Joomla Updates shows the message twice.

Expected
expected
Actual
actual

Solution and Background

The JavaScript code which adds this message checks for a <span> in the specific ID of that plugin output and adds the message there. This worked fine as long as there was only one <span> there. Now we changed the icons to use the <span> tag instead of <i> and guess what, now there are two <span> tags in there. You don't need to be a JavaScript guru to understand what now happens :smile:
The solution is to not target the <span> tag itself but the specific class of that <span>

Testing

Best test with a Joomla 3.4.2 before updating to 3.4.3.

avatar Bakual Bakual - open - 2 Jul 2015
avatar Bakual Bakual - change - 2 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jul 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 2 Jul 2015

I dont understand - once you clear the browser cache this issue does not
exist

On 2 July 2015 at 19:04, Thomas Hunziker notifications@github.com wrote:

Issue

The quickicon plugin which checks for Joomla Updates shows the message
twice.

Expected
[image: expected]
https://cloud.githubusercontent.com/assets/1018684/8483941/b08bcfa2-20f4-11e5-900a-416930bfa77b.PNG
Actual
[image: actual]
https://cloud.githubusercontent.com/assets/1018684/8483943/b46a6624-20f4-11e5-8c31-44374e093876.PNG
Solution and Background

The JavaScript code which adds this message checks for a in the
specific ID of that plugin output and adds the message there. This worked
fine as long as there was only one there. Now we changed the icons
to use the tag instead of and guess what, now there are two
tags in there. You don't need to be a JavaScript guru to
understand what now happens [image: :smile:]
The solution is to not target the tag itself but the specific
class of that
Testing

Best test with a Joomla 3.4.2 before updating to 3.4.3.

You can view, comment on, or merge this pull request online at:

#7323
Commit Summary

  • [fix] Removes the duplicated "Update to Joomla x.y.z" message in the quickicon.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#7323.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar Bakual
Bakual - comment - 2 Jul 2015

Nah, has nothing to do with browser cache.
jQuery('#plg_quickicon_joomlaupdate').find('span').html(updateString); will update each <span> within the tag with the attribute "id=plg_quickicon_joomlaupdate".
The HTML structure for the quickicon is like this:

<li id="plg_quickicon_joomlaupdate">
    <a href="index.php?option=com_joomlaupdate">
        <span class="icon-joomla"></span>
        <span class="j-links-link">Unknown Joomla! ...</span>
    </a>
</li>

See the two <span> tags there?
The icon one comes from
https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/links/link.php#L21
and the content one from
https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/links/link.php#L16

avatar brianteeman
brianteeman - comment - 2 Jul 2015

must have been an earlier issue then with the same outcome but for a
different reason

On 2 July 2015 at 20:58, Thomas Hunziker notifications@github.com wrote:

Nah, has nothing to do with browser cache.
jQuery('#plg_quickicon_joomlaupdate').find('span').html(updateString);
will update each within the tag with the attribute
"id=plg_quickicon_joomlaupdate".
The HTML structure for the quickicon is like this:




  • Unknown Joomla! ...

  • See the two tags there?
    The icon one comes from

    https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/links/link.php#L21
    and the content one from

    https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/links/link.php#L16


    Reply to this email directly or view it on GitHub
    #7323 (comment).

    Brian Teeman
    Co-founder Joomla! and OpenSourceMatters Inc.
    http://brian.teeman.net/

    avatar Bakual
    Bakual - comment - 2 Jul 2015

    Maybe, yes.

    avatar waader
    waader - comment - 2 Jul 2015

    I noticed this behaviour a few days ago and deleting the cache seemed to solve the problem. Now that I logged in again, it´s obvious that the problem persists.
    After applying this patch the duplicated message is gone. Logging in again, everthing is fine.

    @test success! Thanks!

    avatar waader waader - test_item - 2 Jul 2015 - Tested successfully
    avatar 810
    810 - comment - 3 Jul 2015

    same issue on extensions check

    avatar infograf768
    infograf768 - comment - 3 Jul 2015

    Ah, I did know that I had cleared and cleared browser cache and all caches possible. Almost cleared my OS to get rid of the double message... :+1:

    avatar infograf768
    infograf768 - comment - 3 Jul 2015

    I do not have the issue on extension check here.

    avatar gunjanpatel gunjanpatel - change - 3 Jul 2015
    Category Plugins
    avatar Kubik-Rubik
    Kubik-Rubik - comment - 3 Jul 2015

    Thank you @Bakual, this fixes the bug. -> RTC

    avatar Kubik-Rubik Kubik-Rubik - change - 3 Jul 2015
    Labels Added: ?
    avatar Kubik-Rubik Kubik-Rubik - change - 3 Jul 2015
    Milestone Added:
    avatar Kubik-Rubik Kubik-Rubik - change - 3 Jul 2015
    Milestone Added:
    avatar Kubik-Rubik Kubik-Rubik - change - 3 Jul 2015
    Milestone Removed:
    avatar Kubik-Rubik Kubik-Rubik - change - 3 Jul 2015
    Milestone Added:
    avatar Kubik-Rubik Kubik-Rubik - change - 3 Jul 2015
    Milestone Removed:
    avatar Kubik-Rubik
    Kubik-Rubik - comment - 3 Jul 2015

    Merged! Thank you @Bakual.

    avatar zero-24 zero-24 - close - 3 Jul 2015
    avatar Bakual Bakual - change - 3 Jul 2015
    Status Pending Closed
    Closed_Date 0000-00-00 00:00:00 2015-07-03 08:37:21
    Closed_By Bakual
    avatar Bakual Bakual - close - 3 Jul 2015
    avatar Bakual Bakual - close - 3 Jul 2015
    avatar zero-24
    zero-24 - comment - 3 Jul 2015

    @810

    same issue on extensions check

    Can you point us to the check? I'm not sure what do you find on the extensions check see: https://github.com/joomla/joomla-cms/blob/staging/media/plg_quickicon_extensionupdate/js/extensionupdatecheck.js

    avatar Bakual
    Bakual - comment - 3 Jul 2015

    same issue on extensions check

    If it is, then it's a different issue. Did you try with clearing the browser cache?

    avatar Bakual Bakual - head_ref_deleted - 3 Jul 2015
    avatar 810
    810 - comment - 3 Jul 2015

    the same fix did the trick, so its ok now

    avatar zero-24 zero-24 - change - 14 Oct 2015
    Labels Removed: ?

    Add a Comment

    Login with GitHub to post a comment