[#7319] - JPagination link issue href issue in frontend with getListFooter
- Closed
- 2 Aug 2016
- Medium
- Build: staging
- # 7319
- Diff
- gunjanpatel:pagination-link-layout
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure JTracker/HumanTestResults Human Test Results: 0 Successful 2 Failed. Details
User tests: Successful: Unsuccessful:
Problem
When using getListFooter in frontend, having issue in pagination link.
For Example:
If we use in index.php?option=com_content&view=category&id=<category_id>&Itemid=260&limitstart=0
echo $this->pagination->getListFooter();
Note: Layout or pagination file should not be overrided
How to reproduce
To reproduce this issue can manually use above function in code or if you are using JPagination in your component you may check there.
There are many other ways to fix it by overriding JPagination class and JLayout but I think this should be fix in core too.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Front End Layout |
Thanks @Fedik for review
In theory, for frontend $pagination->getPaginationLinks() should fix your problem, there also some other methods that produce different pagination "style"
...
Yes, as I said there are many ways to get it fixed in your project. But this PR will fix issue in core.
In current pull request, check for JFactory::getApplication()->isAdmin() not really safe, as someone can use adminForm on the site also
Yes agree. Many developers are using adminForm in frontend. But this PR is using $item->link in href instead of onclick attribute. So, in any case it is correct to use href also good in SEO perspective.
Difference between using adminForm and simple link, that first do the form submit,
I just thought that someone (who already have component) can expect that there will be the form submit, and such changes can be surprise 
IMHO, The assumption that backend will always use onclick handler, and frontend always href link is misleading.
Rather testing for the app instance within the layout we should have both separately available from the JPagination so that one can use either one as and when required. I guess this is already avaialble but not sure. I'd need to reference back.
This is one part of JPagination that does NOT have an overriding function of some sort. I agree though this logic should be moved to a layout based system.
I have tested this item
I can't reproduce the issue. I tried to reproduce the problem in the joomla staging code with the sample data, but when i used the function in the frontend it worked with no problems.
Tested@icampus
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7319.
I have tested this item
tested it @icampus
I can't reproduce any errors. The link works with no problem in the frontend.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7319.
@gunjanpatel Can you check if this PR is still valid? Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7319.
@gunjanpatel Can you check if this PR is still valid? Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7319.
| Category | Front End Layout | ⇒ | Layout |
Closing as of now as not able to reproduce it in latest. I will reopen if needed.
Thanks.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-02 12:08:14 |
| Closed_By | ⇒ | gunjanpatel |
In theory, for frontend
...
$pagination->getPaginationLinks()should fix your problem,there also some other methods that produce different pagination "style"
In current pull request, check for
JFactory::getApplication()->isAdmin()not really safe, as someone can useadminFormon the site also