? Success

User tests: Successful: Unsuccessful:

avatar n9iels
n9iels
30 Jun 2015

Changes in this PR

This PR removes the orange arrows (dividers) from the breadcrumbs and replace them with > for LTR languages and < for RTL languages. I also add code style to the breadcrumb.less file.

Background information

I made this PR because the current image where not good aligned in the first place. Also, I think you can better use text instead of images. The used images where old and ugly in my opinion.
My first thought was using the Bootstrap icons, like icon-arrow-left, but that will break backward compatibility. Because (unfortunately) not every template supports an icon set.

avatar n9iels n9iels - open - 30 Jun 2015
avatar n9iels n9iels - change - 30 Jun 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 30 Jun 2015
Category Front End Modules
avatar zero-24 zero-24 - change - 30 Jun 2015
Easy No Yes
avatar Bakual
Bakual - comment - 30 Jun 2015

We don't do changes in the breadcrumbs.less file. That one comes from Bootstrap. So please revert the changes there (seems to be only CS, but still).

Changing the breadcrumb module would mean it could change the appearance of templates. Especially because the image can also be overriden by a template.

If you want to get rid of that image, just enter a text separator in the module options. This will do exactly what you try to do here.

avatar Bakual
Bakual - comment - 30 Jun 2015

Closing this PR as it can be solved using an existing parameter of the module.

avatar Bakual Bakual - change - 30 Jun 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-06-30 20:01:01
Closed_By Bakual
avatar Bakual Bakual - close - 30 Jun 2015

Add a Comment

Login with GitHub to post a comment