?
Referenced as Pull Request for: # 7281
avatar smz
smz
28 Jun 2015

Steps to reproduce the issue

  • Perform Joomla! installation
  • Select "Extra steps: Install languages"
  • In "Install Language Packages" select one or more additional language
  • Set "Activate the multilingual feature:" to "Yes"
  • Select "Install localised content"
  • When installation has completed login in the backend and examine the automatically installed articles

Expected result

Articles should have valid metadata in "Publishing Options"

Actual result

All metadata is inserted in the "Meta Description:" as a JSON encoded string: {"robots":"","author":"","rights":"","xreference":""}

Additional comments

Unrelated, but I can't understand why when performing the "Extra steps: Install languages" the default value for "Activate the multilingual feature:" is "no". Wouldn't it be more logical that the default would be "Yes"?

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
2.00

avatar smz smz - open - 28 Jun 2015
avatar smz smz - change - 28 Jun 2015
Build 3.4.2-rc2 staging
avatar smz
smz - comment - 28 Jun 2015

@infograf768 We have this small issue in multilingual installation...

avatar smz smz - change - 28 Jun 2015
Title
Automatically installed localised content: Errors in pubishing option
Automatically installed localised content: errors in metadata
avatar smz
smz - comment - 28 Jun 2015

I think I found where the problem lies: /installation/model/languages.php at line 1127 we set 'metadesc' to that value and we should probably set it to a null string.

I'm unsure if what we set at line 1125 for 'metadata' is correct...

In that file we have another small issue: article title is set to the PLG_ARTICLE_BUTTON_ARTICLE localised constant. This might be OK for some languages, but it surely isn't for Italian where the translation is "Collega articolo' ("Link article"). We probably should introduce a new string constant...

I can write a PR for the above, but it must be decided if we want it for 3.4.2 (then no new string constant should be introduced) or for 3.5 (then a new string constant *might be introduced*).

avatar infograf768
infograf768 - comment - 28 Jun 2015

Unrelated, but I can't understand why when performing the "Extra steps: Install languages" the default value for "Activate the multilingual feature:" is "no". Wouldn't it be more logical that the default would be "Yes"?

Nope. Most installs are not multilingual. They are monolingual and default language would be another language than en-GB, the one added to installation.

Agree concerning metadesc. Not
'metadesc' => '{"robots":"","author":"","rights":"","xreference":""}',
but
'metadesc' => '',

Introducing a new string in installation to replace "PLG_ARTICLE_BUTTON_ARTICLE" looks useless as anyway the article created is just a sample and might very soon be edited/replaced.

avatar infograf768
infograf768 - comment - 28 Jun 2015

But we could use: COM_CONTENT_CONTENT_TYPE_ARTICLE instead.
This would make:

        $newlanguage = new JLanguage($itemLanguage->language, false);
        $newlanguage->load('com_content.sys', JPATH_ADMINISTRATOR, $itemLanguage->language, true);
        $title = $newlanguage->_('COM_CONTENT_CONTENT_TYPE_ARTICLE`');
avatar smz
smz - comment - 28 Jun 2015

This can be closed as we have a PR (#7281)

avatar brianteeman brianteeman - change - 28 Jun 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-06-28 10:56:15
Closed_By brianteeman
avatar brianteeman brianteeman - close - 28 Jun 2015

Add a Comment

Login with GitHub to post a comment