Feeling Lucky
?
[#7268] - Add (array) to JRouter::_rules return value
- Closed
- 11 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 7268
- Diff
- asika32764:patch-8
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Currently our router rules should return array, otherwise will return this error
Fatal error: Unsupported operand types in /path/to/joomla/libraries/cms/router/router.php on line 593
There are two choice:
- Throw Exception to notice developer that they return wrong type.
- Just force all value to array to ignore error.
I try to force return value to array that will prevent fatal error.
How to Test
Add a custom plugin or in any plugin onAfterInitialise event, add this code:
$closure = function(\JRouterSite $router, \JUri $uri)
{
return;
};
$app = JFactory::getApplication();
$router = $app::getRouter();
$router->attachParseRule($closure, $router::PROCESS_BEFORE);Then it will raise fatal error in frontend.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Router / SEF |
| Easy | No | ⇒ | Yes |
| Title |
|
||||||
larapetersen
- comment
- 11 Jul 2015
Fix worked, error gone after applying the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7268.
roland-d
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-11 15:14:55 |
| Closed_By | ⇒ | roland-d |
| Milestone |
Added: |
||
@asika32764: Got some trouble getting the code right to produce the error, but the fix worked! :)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7268.