? ? Success

User tests: Successful: Unsuccessful:

avatar asika32764
asika32764
25 Jun 2015

.

bc2aaad 25 Jun 2015 avatar asika32764 CS
avatar asika32764 asika32764 - open - 25 Jun 2015
avatar asika32764 asika32764 - change - 25 Jun 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2015
Labels Added: ?
avatar n9iels
n9iels - comment - 25 Jun 2015

not sure, but I thought that that extra tab is only necessary when there are multiple variables with = signs

avatar mbabker
mbabker - comment - 25 Jun 2015

It's an optional thing to align multiple variable assignments on the equal sign (using spaces, not tabs) in our code style rules. The trends in our code right now are to align things. Obviously, there isn't much to align to for a single variable.

avatar n9iels
n9iels - comment - 25 Jun 2015

aha, thanks :)
But looks good to me :+1:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7262.

avatar n9iels n9iels - test_item - 25 Jun 2015 - Tested successfully
avatar zero-24 zero-24 - change - 25 Jun 2015
Category Code style
avatar zero-24 zero-24 - change - 25 Jun 2015
The description was changed
Status Pending Ready to Commit
Easy No Yes
avatar zero-24
zero-24 - comment - 25 Jun 2015

RTC Thanks @asika32764


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7262.

avatar zero-24 zero-24 - change - 25 Jun 2015
Labels Added: ? ?
avatar Bakual Bakual - change - 25 Jun 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-06-25 20:01:02
Closed_By Bakual
avatar Bakual Bakual - close - 25 Jun 2015
avatar zero-24 zero-24 - close - 25 Jun 2015
avatar Bakual Bakual - reference | db3bb72 - 25 Jun 15
avatar Bakual Bakual - merge - 25 Jun 2015
avatar Bakual Bakual - close - 25 Jun 2015
avatar zero-24 zero-24 - change - 25 Jun 2015
Milestone Added:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment