Feeling Lucky
?
[#7253] - Implementing "No Matching Results" in Users modal Fixes #7236
- Closed
- 23 Jun 2015
- Medium
- Build: staging
- # 7253
- Diff
- Kubik-Rubik:usermodal
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is a code style review of Brian's PR #7236.
Kudos to @brianteeman and @infograf768!
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Kubik-Rubik
- comment
- 23 Jun 2015
@brianteeman Please check my change and add it to your PR. I will close this PR then. Thanks!
brianteeman
- comment
- 23 Jun 2015
Done
On 23 June 2015 at 13:45, Viktor Vogel notifications@github.com wrote:
@brianteeman https://github.com/brianteeman Please check my change and
add it to your PR. I will close this PR then. Thanks!—
Reply to this email directly or view it on GitHub
#7253 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Kubik-Rubik
- comment
- 23 Jun 2015
Thank you, @brianteeman! I close this PR in favor of #7236.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-23 12:49:50 |
| Closed_By | ⇒ | Kubik-Rubik |
You could have just done a pr against my branch!!
On 23 Jun 2015 13:29, "Viktor Vogel" notifications@github.com wrote: