[#7244] - Implementing "No Matching Results" in Categories modal
- Closed
- 3 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 7244
- Diff
- infograf768:categories_modal
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Similar patch as #7232, #7236, #7234, #7231 for Categories.
To test, install a basic multilingual site and set associations in the language filter plugin. Create at least one article category for each language (2 languages are enough).
Edit a category. Click on the Associations Tab. Select a category. The list of categories associated to that peculiar language display in a modal.
When filtering and if no results, the display is just empty instead of the usual message "No Matching Results"
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
It is a "module" modal, not a "modules" modal and it does not propose a list comparable to the Modules Manager afaik.
Note: I think we could use the categories modal instead of the dropdown in many places btw. Would be easier to choose categories from the modal as we can filter.
I couldnt see where the module one is used.
The modal is definitely better that the select list especially on larger
sites
(Sent from phone -apologies for tyoos)
On 22 Jun 2015 5:27 pm, "infograf768" notifications@github.com wrote:
It is a "module" modal, not a "modules" modal and it does not propose a
list comparable to the Modules Manager afaik.Note: I think we could use the categories modal instead of the dropdown in
many places btw. Would be easier to choose categories from the modal as we
can filter.—
Reply to this email directly or view it on GitHub
#7244 (comment).
This PR works as expected
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7244.
| Category | ⇒ | Administration UI/UX |
| Easy | No | ⇒ | Yes |
| Labels |
Added:
?
|
||
Thank you, @infograf768!
| Status | Pending | ⇒ | Ready to Commit |
RTC to match the status on github
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7244.
I couldnt see where the module one is used.
It is used when editing a Menu item => Module Assignment=> Click on a module name in the list.
@infograf768 ok thanks - as this one can only ever display a module the update isnt required
Thank you once again @infograf768! Merged.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-03 12:22:35 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
Thanks. I saw the modal but didn't see where it was used. There is a module
modal I couldn't see in use as well.