?
avatar artur-stepien
artur-stepien
22 Jun 2015

$key is a numeric index of a field in $row array not a field/column name. $row variable is an array indexed starting from zero. So $key is unique . Using column name in this param can result in unexpected results.

This mistake is in here: libraries/joomla/database/driver.php

Here is my pull request:
#7239

avatar artur-stepien artur-stepien - open - 22 Jun 2015
avatar zero-24 zero-24 - change - 22 Jun 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 22 Jun 2015

@artur-stepien since we using now our own Issue Tracker (http://issues.joomla.org/tracker/joomla-cms) you don't need to open a extra Issue if you have a Pull Request.

So I closing here as we have allready your pull request #7239 :+1: Thanks :smile:

avatar zero-24 zero-24 - change - 22 Jun 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-06-22 10:45:01
Closed_By zero-24
avatar zero-24 zero-24 - close - 22 Jun 2015
avatar zero-24 zero-24 - close - 22 Jun 2015
avatar artur-stepien
artur-stepien - comment - 22 Jun 2015

So I suppose from now on I should just describe Pull Requests as they where Bug Reports or Feature Request?

avatar zero-24
zero-24 - comment - 22 Jun 2015

Yes :smile:

If you have code please open only a pull request and put all information to test there.
If you have a issue (without code to fix it) please open a issue with all information to reproduce.

If you have a new Feature with code please open a pull request.
If you have a feature request (without code) please open a issue with all information.

avatar artur-stepien
artur-stepien - comment - 22 Jun 2015

Nice :D

avatar artur-stepien
artur-stepien - comment - 22 Jun 2015

This trackers has few problems. NO code formatting in comments. And I had like 5-6 times problems with MySQL connection while trying to post comment. So it is work in progress?

avatar zero-24
zero-24 - comment - 22 Jun 2015

@artur-stepien

Code formatting is like github see: https://guides.github.com/features/mastering-markdown/ and https://help.github.com/articles/github-flavored-markdown/
For Syntax highlighting see: https://help.github.com/articles/github-flavored-markdown/#syntax-highlighting

And I had like 5-6 times problems with MySQL connection while trying to post comment.

I can confirm that but now it is gone. I never experienced that bevor :smile:

avatar artur-stepien
artur-stepien - comment - 22 Jun 2015

It would be nice to add this markdown links near editor. There can be more questions like mine :)

Add a Comment

Login with GitHub to post a comment