[#7231] - Implementing "No Matching Results" in Articles modal
- Closed
- 3 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 7231
- Diff
- infograf768:articles_modal
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
When editing an article and clicking on the Article button to insert an article link in the edited article, the list of articles is displayed in a modal wndow.
When filtering and if no results, the display is just empty instead of the usual message "No Matching Results"
This patch is just implementing the message in the modal when necessary.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration UI/UX |
| Easy | No | ⇒ | Yes |
@infograf768 Thank you, works as described. Could you please move the code one indent to the right within the else statement ()?
@brianteeman Please also for your PRs, thanks!
Not 100% sure where you want the indent - tried with #7236 - was that what
you meant?
If not please do a PR against one of my branches
On 23 June 2015 at 11:22, Viktor Vogel notifications@github.com wrote:
@infograf768 https://github.com/infograf768 Thank you, works as
described. Could you please move the code one indent to the right within
the else statement ()?
@brianteeman https://github.com/brianteeman Please also for your PRs,
thanks!—
Reply to this email directly or view it on GitHub
#7231 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman I mean the code style. Just move the whole code section within the else statement one indent to the right.
Please check #7236
On 23 June 2015 at 11:31, Viktor Vogel notifications@github.com wrote:
@brianteeman https://github.com/brianteeman I mean the code style. Just
move the whole code section within the else statement one indent to the
right.—
Reply to this email directly or view it on GitHub
#7231 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@Kubik-Rubik
Indent corrected and as well for #7244
@infograf768 Thank you! The closing tag for enforeach is one indent too far right but it's okay. If you have the time, you can still fix it.
I will run the Travis job once again and then set the PR to RTC. Thanks again!
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Ready to Commit |
RTC to match the status on github
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7231.
Thank you @infograf768! Merged.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-03 12:57:12 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
Confirmed issue and confirmed fix
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7231.