? ? Success

User tests: Successful: Unsuccessful:

avatar astridx
astridx
20 Jun 2015

If my solution will be applied, this is also a solution for the issue
#7115

See the failure

  1. Go to the Extensions | Module Manager and ensure, that you have at least two modules of the type search for the location site. One is published and another is unpublished.

snap1

  1. Switch to Extension Manager|Manage and disable the Modul “Search” for the location site.

snap2

  1. Go back to Extensions | Module Manager and see, that the Status show wrong values. The published Module looks like unpublished and the unpublished value looks like trashed.

snap3

Apply my patch

  1. Go to the Extensions | Module Manager and ensure, that you have at least two modules of the type "Search" for the location site. One is published and another is unpublished.

snap1

  1. Switch to Extension Manager|Manage and disable the Module “Search” for the location site.

snap2

  1. Go back to Extensions | Module Manager and see, that the Status did not show the wrong values any more. The Module with disabled extensions has another icon with a message, that explained why you could not change the status in this list.

snap3

I am pleased about any feedback

avatar astridx astridx - open - 20 Jun 2015
avatar astridx astridx - change - 20 Jun 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jun 2015
Labels Added: ? ?
avatar astridx astridx - change - 20 Jun 2015
The description was changed
avatar astridx astridx - change - 20 Jun 2015
The description was changed
avatar Bakual
Bakual - comment - 20 Jun 2015

I like that solution. Very well done, thanks already!

I added some comments.

avatar Bakual Bakual - change - 20 Jun 2015
Milestone Added:
avatar Bakual Bakual - test_item - 20 Jun 2015 - Tested successfully
avatar Bakual
Bakual - comment - 20 Jun 2015

Btw: Test was successful.

avatar brianteeman
brianteeman - comment - 20 Jun 2015

In the tooltip it is enough to say. This module is disabled. Use Extension Manager... ... to enable it.

We don't usually have any p markup in a tooltip and with a simpler text you probably don't even need a line break.

avatar astridx
astridx - comment - 20 Jun 2015

Thank you for the feedback and the test.
I applied Bakuals suggestions.
@brianteeman
Are you sure, that the module is disabled? My point of view is this, that the module has the state published. Only the extension is (perhaps by mistake) disabled.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7221.

avatar brianteeman
brianteeman - comment - 20 Jun 2015

In your instructions you state to disable the module


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7221.

avatar zero-24 zero-24 - change - 20 Jun 2015
Easy No Yes
avatar zero-24 zero-24 - change - 20 Jun 2015
Category Administration Language & Strings UI/UX
avatar astridx
astridx - comment - 21 Jun 2015

@brianteeman
Yes, you are right;

Now (and in my subconscious perhaps even earlier, because I stated it in my one text) that I have been thinking about it more precisely, I changed my opinion. Now I agree that a module is an extension (Just as a horse is an animal ….).

I've changed my text in your text :-).

Thanks for your note.

avatar brianteeman
brianteeman - comment - 21 Jun 2015

Language string looks good now

avatar brianteeman
brianteeman - comment - 21 Jun 2015

Tested as per instructions and looks good to me and resolves a silly bug (note before this patch you can click on publish for the module and it will say 1 module successfully published. but will stay unpublished because the module is disabled


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7221.

avatar brianteeman brianteeman - test_item - 21 Jun 2015 - Tested successfully
avatar zero-24 zero-24 - change - 21 Jun 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 21 Jun 2015

Thanks :smile: RTC!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7221.

avatar zero-24 zero-24 - change - 21 Jun 2015
Labels Added: ?
avatar mdemop mdemop - test_item - 19 Jul 2015 - Tested successfully
e7ca27f 20 Jul 2015 avatar brianteeman NOTE
avatar astridx astridx - change - 6 Aug 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-08-06 11:04:54
Closed_By astridx
avatar astridx astridx - close - 6 Aug 2015
avatar astridx astridx - head_ref_deleted - 6 Aug 2015
avatar zero-24 zero-24 - change - 6 Aug 2015
Milestone Removed:
avatar zero-24
zero-24 - comment - 6 Aug 2015

@astridx any reason to close / delete the branch?

avatar joomla-cms-bot joomla-cms-bot - change - 6 Aug 2015
Labels Removed: ?
avatar astridx astridx - head_ref_restored - 6 Aug 2015
avatar astridx
astridx - comment - 6 Aug 2015

Sorry :(

avatar astridx astridx - change - 6 Aug 2015
Status Closed New
Closed_Date 2015-08-06 11:04:52
Closed_By astridx
avatar astridx astridx - reopen - 6 Aug 2015
avatar zero-24 zero-24 - change - 6 Aug 2015
Status New Ready to Commit
avatar zero-24
zero-24 - comment - 6 Aug 2015

No Problem RTC'ing again :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7221.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 6 Aug 2015
Milestone Added:
avatar infograf768
infograf768 - comment - 7 Aug 2015

This should be changed I guess:
+COM_MODULES_MSG_MANAGE_EXTENSION_DISABLED="This module is disabled. Use Extension Manager | Manage to enable it."
as the wording "manager" has been taken off from en-GB in a recent PR

So, maybe something like
+COM_MODULES_MSG_MANAGE_EXTENSION_DISABLED="This module is disabled. Use Extension => Manage to enable it."

avatar zero-24
zero-24 - comment - 7 Aug 2015

@astridx see: astridx#2 that implements the tip by @infograf768 Thanks :smile:

avatar infograf768
infograf768 - comment - 9 Aug 2015

Oops: should be "Extensions => Manage" and not "Extension => Manage"

avatar joomla-cms-bot
joomla-cms-bot - comment - 1 Oct 2015

This PR has received new commits.

CC: @Bakual, @brianteeman, @mdemop


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7221.

avatar Bakual Bakual - change - 4 Oct 2015
Labels Removed: ?
avatar Bakual
Bakual - comment - 4 Oct 2015

Looks like a wrong merge commit. PR is currently messed up a lot.

Removing RTC.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Oct 2015
Labels Added: ?
avatar Bakual Bakual - change - 4 Oct 2015
Status Ready to Commit Pending
avatar Bakual Bakual - change - 4 Oct 2015
Labels Removed: ?
avatar astridx
astridx - comment - 4 Oct 2015

Sorry, I tided up … I will learn some more about git before I try a next PR :-(
Is it possible to undo the last merge? I do not want to make another failure.....

avatar Bakual
Bakual - comment - 4 Oct 2015

In Git everything is possible :smile:
You can revert the commit or check out an earlier one and force-push the branch. Both would solve it.

avatar zero-24
zero-24 - comment - 5 Oct 2015

@astridx see:
https://github.com/blog/2019-how-to-undo-almost-anything-with-git

git revert 7e731a89f1043e9c015d47ea2817064b3b057b36
git commit -am 'try to revert the bad merge'
git push origin ModuleList -f 

Should do the trick and revert the commit that breaks everything ;)

other way arround (https://www.atlassian.com/git/tutorials/viewing-old-commits/):

git checkout 5abbe02be69579b9bcbc8a58b78a3c0bdccb090e
git commit -am 'try to revert the bad merge'
git push origin ModuleList -f 

If that don't work we can redo all changes that can be shown here:
staging...astridx:5abbe02be69579b9bcbc8a58b78a3c0bdccb090e

If you need more info about git in general see:
https://git-scm.com/book/en/v2
http://phproberto.com/en/32-git-github-basic-workflow
https://www.youtube.com/watch?v=FsNjqy-Q4mc

avatar astridx
astridx - comment - 5 Oct 2015

Sorry, but it was not able to revert the merge. It ends all the time
that with the error fatal: bad object
7e731a8.

What does it mean:
“If that don't work we can redo all changes that can
be shown here:”

Do you redo the whole PR or only my bad merge?

avatar zero-24
zero-24 - comment - 5 Oct 2015

Redo the pr is the easyest. I have no git client on my phone ????

avatar astridx
astridx - comment - 5 Oct 2015

OK, then you delete this PR or should I do this? Should I try to make the new PR?

avatar zero-24
zero-24 - comment - 5 Oct 2015

Yes you can do a new PR that based on the current staging and close this here.

Thanks.

avatar astridx astridx - reference | a42cbe9 - 5 Oct 15
avatar astridx
astridx - comment - 5 Oct 2015

New PR: Fix a failure in the Module List #8020

avatar astridx astridx - change - 5 Oct 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-10-05 21:43:09
Closed_By astridx
avatar astridx astridx - close - 5 Oct 2015
avatar zero-24 zero-24 - change - 6 Oct 2015
Milestone Removed:

Add a Comment

Login with GitHub to post a comment