User tests: Successful: Unsuccessful:
If my solution will be applied, this is also a solution for the issue
#7115
I am pleased about any feedback
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
Milestone |
Added: |
Btw: Test was successful.
In the tooltip it is enough to say. This module is disabled. Use Extension Manager... ... to enable it.
We don't usually have any p markup in a tooltip and with a simpler text you probably don't even need a line break.
Thank you for the feedback and the test.
I applied Bakuals suggestions.
@brianteeman
Are you sure, that the module is disabled? My point of view is this, that the module has the state published. Only the extension is (perhaps by mistake) disabled.
In your instructions you state to disable the module
Easy | No | ⇒ | Yes |
Category | ⇒ | Administration Language & Strings UI/UX |
@brianteeman
Yes, you are right;
Now (and in my subconscious perhaps even earlier, because I stated it in my one text) that I have been thinking about it more precisely, I changed my opinion. Now I agree that a module is an extension (Just as a horse is an animal ….).
I've changed my text in your text :-).
Thanks for your note.
Language string looks good now
Tested as per instructions and looks good to me and resolves a silly bug (note before this patch you can click on publish for the module and it will say 1 module successfully published.
but will stay unpublished because the module is disabled
Status | Pending | ⇒ | Ready to Commit |
Thanks RTC!
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-06 11:04:54 |
Closed_By | ⇒ | astridx |
Milestone |
Removed: |
Labels |
Removed:
?
|
Sorry :(
Status | Closed | ⇒ | New |
Closed_Date | 2015-08-06 11:04:52 | ⇒ | |
Closed_By | astridx | ⇒ |
Status | New | ⇒ | Ready to Commit |
No Problem RTC'ing again
Labels |
Added:
?
|
Milestone |
Added: |
This should be changed I guess:
+COM_MODULES_MSG_MANAGE_EXTENSION_DISABLED="This module is disabled. Use Extension Manager | Manage to enable it."
as the wording "manager" has been taken off from en-GB in a recent PR
So, maybe something like
+COM_MODULES_MSG_MANAGE_EXTENSION_DISABLED="This module is disabled. Use Extension => Manage to enable it."
@astridx see: astridx#2 that implements the tip by @infograf768 Thanks
Oops: should be "Extensions => Manage" and not "Extension => Manage"
This PR has received new commits.
CC: @Bakual, @brianteeman, @mdemop
Labels |
Removed:
?
|
Looks like a wrong merge commit. PR is currently messed up a lot.
Removing RTC.
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Pending |
Labels |
Removed:
?
|
Sorry, I tided up … I will learn some more about git before I try a next PR :-(
Is it possible to undo the last merge? I do not want to make another failure.....
In Git everything is possible
You can revert the commit or check out an earlier one and force-push the branch. Both would solve it.
@astridx see:
https://github.com/blog/2019-how-to-undo-almost-anything-with-git
git revert 7e731a89f1043e9c015d47ea2817064b3b057b36
git commit -am 'try to revert the bad merge'
git push origin ModuleList -f
Should do the trick and revert the commit that breaks everything ;)
other way arround (https://www.atlassian.com/git/tutorials/viewing-old-commits/):
git checkout 5abbe02be69579b9bcbc8a58b78a3c0bdccb090e
git commit -am 'try to revert the bad merge'
git push origin ModuleList -f
If that don't work we can redo all changes that can be shown here:
staging...astridx:5abbe02be69579b9bcbc8a58b78a3c0bdccb090e
If you need more info about git in general see:
https://git-scm.com/book/en/v2
http://phproberto.com/en/32-git-github-basic-workflow
https://www.youtube.com/watch?v=FsNjqy-Q4mc
Redo the pr is the easyest. I have no git client on my phone
OK, then you delete this PR or should I do this? Should I try to make the new PR?
Yes you can do a new PR that based on the current staging and close this here.
Thanks.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-05 21:43:09 |
Closed_By | ⇒ | astridx |
Milestone |
Removed: |
I like that solution. Very well done, thanks already!
I added some comments.