[#7213] - Updating icomoon.css from icomoon.less
- Closed
- 22 Jun 2015
- Medium
- Build: staging
- Easy Test
- # 7213
- Diff
- Bakual:UpdateIcoMoon
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Today @Hutchy68 and me found out that our /media/jui/css/icomoon.css file isn't up to date with the related /media/jui/less/icomoon.less file.
This PR regenerates the CSS file from the LESS file.
Notable changes are the missing .icon-expired icon and some margins to hits and time icon.
Allthough I don't know if the second change really was done in the correct place. It comes from #5512. Sounds to me like something which should have been fixed in template level and not in JUI library. But since it's there quite some time already I kept it for now.
It also fixes some minor codestyle stuff in the LESS file.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
It is like that in the original LESS file and in all other LESS files (Hathor, Isis and Protostar) I checked.
I just assumed it is being something that was changed recently and forgot to be updated in the CSS.
If we want to change that order, it should probably be done as a separate PR and be done in all instances.
Or it could be the other way around. Changed in the css and forgotten in the less ;)
Rightly or wrongly it is in the css file that people have been using on their sites so this PR has changed the behaviour
I just checked and the css file has always been in the current order and never matched the LESS
Has been changed in all LESS and template.css files with
JC Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30660
Commit: cb07089
If I chaneg the LESS file, it would mean that all depending templates would be changed as well. So that's no option in this PR 
zero-24
- | Category | ⇒ | Templates (admin) Templates (site) |
| Easy | No | ⇒ | Yes |
Why do we have non IcoMoon styling in the icomoon.less file?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-22 14:00:52 |
| Closed_By | ⇒ | Bakual |
Can I ask why the load order has been changed with svg now last instead of first. SVG is recommended to be loaded first to improve quality in windows etc
Source https://icomoon.io/#post/318