@dgt41 any way to easy test it? e.g. where the layout is called?

@zero-24 Sorry should mention testing:

To Test this

go to http://localhost/administrator/index.php?option=com_menus&view=menus

and click on any of the Linked modules

Inspect the source page and verify that a parameter name="[the title of the modal]" is inside iframe tag

Tested and confirmed that name did not exist in the iframe before the patch and does exist after the patch

Tested OK.
We have 2 tests: RTC?

RTC. Thanks

thank @dgt41 and all for testing

Tested with selenium and works very nice, see: http://www.youtube.com/watch?v=Snm2lE81Ahg

Wondering if we should do:

if (isset($params['title']))
{
   $iframeAttributes['name']  => $params['title'];

In theory you should that, but
1. Bootstrap modal are broken (visually) if you don’t pass a title
2. We do pass ALWAYS a title for core components

But the check will not hurt I guess, 3PD might do something different

@dgt41: if you do, I'm ready for re-testing...

@dgt41, actually with the modal you suggested for testing (/administrator/index.php?option=com_menus&view=menus + Linked Modules) I don't see the name attribute. Also, when I previously tested, I'm quite sure it was name="", but I thought it was OK...

... hold on! I activated the wrong patch...!!! sorry!

#test confirmed OK: iframe now has name="Edit module settings"

Sorry for the confusion...

ehmm... why this PR has the Unit/System Tests label?

Thanks Sergio,
Is needed for selenium (testing)

ah! OK!!! tnks!

@javigomez does $iframeAttributes['name'] => 'Modal - ' . $params['title']; pass your accessibility tests?

@dgt41 @javigomez So, what is the state of this PR? Do we need a change or can we merge this?

@Kubik-Rubik Victor I have no idea. @javigomez made a post that there was an accessibility error if name is same as the title of the iframe. I proposed to suffix something to the title, but then Javier removed that post, so honestly I have no clue ????

hmm.... Reading https://developer.mozilla.org/en/docs/Web/HTML/Element/iframe#name-attribute

name
A name for the embedded browsing context (or frame). This can be used as the value of the target attribute of an <a> or <form> element, or the formtarget attribute of an <input> or <button> element.

It doesn't seems that equating it to title is a good choice...

@Kubik-Rubik Victor since ther is no response from @javigomez I will suggest to change the milestone to 3.5.0

Sorry folks, I missed the notifications here. I was checking the accessibiltiy documentation (witch I'm not experienced) and from what I could see the current pull accomplish what is expected. And it allows us to work with iFrames in system tests witch is the reason why we oppened this issue #7207.

So for me we are good to go.

Thanks all ^_^

Thanks @javigomez
@Kubik-Rubik ditch my last comment, you can merge this for 3.4.4 ????

So, if the iframe title is "Test iframe", do you expect this to be a valid "... value of the target attribute of an <a> or <form> element"?

For reference:

values for the target attribute of an <a> or <form> element can be:

• _blank (Opens the linked document in a new window or tab)
• _self (Opens the linked document in the same frame as it was clicked. This is default.)
• _parent (Opens the linked document in the parent frame)
• _top (Opens the linked document in the full body of the window)
• framename (Opens the linked document in a named frame) Must start with an alpha character and can contain hyphen(-), underscore(_), colon(:)

@smz So, what is your suggestion how to do it right? Should we apply a filter on the title to get a valid name?

@Kubik-Rubik I guess the easiest thing here would be $iframeAttributes[’title’] instead of $iframeAttributes['name']

Sorry, Victor, I'm on vacation and I'm not even sure I'll be willing to contribute to Joomla again when I'll be back: I'm afraid I've fought too many uphill fights to feel comfortable contributing.

But yes, I think a filter or "transforming function" to enforce the rules of the game is needed.

Regards,

Sergio

On 2015-07-15 14:44, Viktor Vogel wrote:

@smz https://github.com/smz So, what is your suggestion how to do it right? Should we apply a filter on the title to get a valid name?

—
Reply to this email directly or view it on GitHub #7211 (comment).

Merged - thanks!