Wrong branch, sorry.

Nick,

Can you point me to a document on how to do a pull request for Joomla 2.5? I thought 2.5.x was the right branch and that is what I tried to do.

Thanks

Hi Jonathan,

Yes, go to your branch from which you want to do the pull request, click the pull request button, then you'll see a screen similar to the following screenshot:

Click the Base branch master drop down to select 2.5.x

Hope this helps! Let me know if you have any questions.

Sorry Nick, I got confused. I thought this traffic was related to my pull request 647 (which is still open). Would you please verify that I've done the pull request correctly: #647

By the way, this pull request duplicates a fix for the onContentPrepare callback for Joomla 2.5.x that was already done for onContentPrepare for Joomla 3.5.

Thanks

-Jonathan

No problem, Jonathan!

Yes, your pull request looks OK to me. It needs at least one more good test (by another tester) to be considered for inclusion.

Cheers,

@nicksavov Hi Nick, there is another test now (by Peter Van Westen) for my patch. See #647. Peter indicates he tested it in the corresponding tracker item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=11410&tracker_item_id=29968.

Thanks

-Jonathan

@jmcameron It needs at least two good tests to patch. One more to go.

Cheers,
Nick