[#7206] - [New feature] Version History limit context
- Closed
- 25 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 7206
- Diff
- Devportobello:versionHistoryContext
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Context
When using Joomla! versioning feature, we are able to fix a number of history limit in configuration.
Follow of #7191
Actual limitation
This history limit is only applied of the whole component context eg: com_banners.
If you want to got (wanna keep using banners component for exemple) only 10 history limit for banner and 5 for client (dunno if this could be real) this is actually not possible.
How to test
Part1
- Create 1 banner, save and edit multiple time (you need versioning history ON and history limitation setup)
- Then create 1 client, save and edit multiple time.
- Both got same history limitation
- Erase all
Part2
Apply patch.
Go to administrator\components\com_banners and edit config.xml and add after
<field
name="history_limit"
type="text"
filter="integer"
label="JGLOBAL_HISTORY_LIMIT_OPTIONS_LABEL"
description="JGLOBAL_HISTORY_LIMIT_OPTIONS_DESC"
default="5"
/>this
<field
name="history_limit_client"
type="text"
filter="integer"
label="COM_BANNERS_CLIENT_HISTORY_LIMIT_OPTIONS_LABEL"
description="COM_BANNERS_CLIENT_HISTORY_LIMIT_OPTIONS_DESC"
default="5"
/>
<field
name="history_limit_banner"
type="text"
filter="integer"
label="COM_BANNERS_BANNER_HISTORY_LIMIT_OPTIONS_LABEL"
description="COM_BANNERS_BANNER_HISTORY_LIMIT_OPTIONS_DESC"
default="5"
/>OR
Use this repo / ZIP.
Repeat the part1 after having different setup for history limitation using 2 new context (banner / client) eg: 3 for maximum version client, 4 for maximum version banner and 5 for the base maximum version
You would be able to got different number of history limit.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Libraries |
@smz @Devportobello try this banner release: https://github.com/zero-24/banners/releases/tag/version_history_test
follow the instruction on the release and here. For me it works Thanks @Devportobello
PR works as intended.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7206.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7206.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
Kubik-Rubik
- | Milestone |
Added: |
||
| Milestone |
Removed: |
||
roland-d
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-25 16:07:00 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
The link to "this repo / ZIP" mentioned in the PR description does not work.
Why don't you create a "sister PR" for com_banners (which btw should be on its way out...)? That would make testers life a lot easier...
If the com_banners mods is not meant to stay there you can clearly state that in the PR description and then close it when/if this PR is merged.