?

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
16 Jun 2015

Better external resource detection in JHtml::includeRelativeFiles()

Test
Add in template index.php:
JHtml::_('script', '//maps.googleapis.com/maps/api/js?v=3&sensor=false');
Open site in browser and check the page source.

Actual result
JHtml does not add //maps.googleapis.com/maps/api/js to the page <head>

Expected
Somewhere between <head> tags you should be able to see:

<script src="//maps.googleapis.com/maps/api/js?v=3&sensor=false" type="text/javascript"></script>
avatar Fedik Fedik - open - 16 Jun 2015
avatar zero-24 zero-24 - change - 16 Jun 2015
Category Libraries
avatar zero-24 zero-24 - change - 16 Jun 2015
Status New Pending
Easy No Yes
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 17 Jun 2015

Confirmed issue and confirmed the PR fixes it


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7184.

avatar brianteeman brianteeman - test_item - 17 Jun 2015 - Tested successfully
avatar ghazal
ghazal - comment - 18 Jun 2015

@test
Nice catch.
Like B. Teeman, confirmed issue and PR solves it.

avatar brianteeman brianteeman - alter_testresult - 18 Jun 2015 - ghazal: Tested successfully
avatar brianteeman brianteeman - change - 18 Jun 2015
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 18 Jun 2015

Setting RTC thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7184.

avatar brianteeman brianteeman - change - 18 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - close - 11 Jul 2015
avatar mbabker mbabker - change - 11 Jul 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-07-11 15:00:19
Closed_By mbabker
avatar mbabker mbabker - close - 11 Jul 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment