User tests: Successful: Unsuccessful:
Better external resource detection in JHtml::includeRelativeFiles()
Test
Add in template index.php:
JHtml::_('script', '//maps.googleapis.com/maps/api/js?v=3&sensor=false');
Open site in browser and check the page source.
Actual result
JHtml does not add //maps.googleapis.com/maps/api/js
to the page <head>
Expected
Somewhere between <head>
tags you should be able to see:
<script src="//maps.googleapis.com/maps/api/js?v=3&sensor=false" type="text/javascript"></script>
Category | ⇒ | Libraries |
Status | New | ⇒ | Pending |
Easy | No | ⇒ | Yes |
Labels |
Added:
?
|
Status | Pending | ⇒ | Ready to Commit |
Setting RTC thanks
Labels |
Added:
?
|
Milestone |
Added: |
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-11 15:00:19 |
Closed_By | ⇒ | mbabker |
Labels |
Removed:
?
|
Confirmed issue and confirmed the PR fixes it
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7184.