User tests: Successful: Unsuccessful:
The dropdowns are cut off at the bottom of page when appearing on the end of the site.
Example: mod_smart_search
To test please apply this patch an test if it works in different browsers and the other dropdowns work as expected.
Thanks!
Labels |
Added:
?
|
Status | New | ⇒ | Pending |
Easy | No | ⇒ | Yes |
Category | ⇒ | Templates (admin) UI/UX |
Any reason for not adding the classes to media/jui/bootstrap-extended.less and then run generatecss.php ?
To be honest just my lack of knowledge how things work together in the structure. So should i remove it from isis and put it into bootstrap-extended.less, yes?
Any reason for not adding the classes to media/jui/bootstrap-extended.less and then run generatecss.php ?
Is the change something that needs to be made to all templates or is this a template specific fix? If the former, you have a case for using the extended LESS file. If it's specific to the template, this is fine.
It works for me with Firefox (38.0.5), IE (11.0.20) and Chrome (43.0.2357.125) on Windows 7.
But it worked only in the Module Manager.
I try to open a drop down in Article Manager | Edit Article |Options and here the bottom was still cut off.
It works fine on Firefox 38.0.5 and Windows 7 and IE 11.0.9600.17843 on Windows 7. It works in the Article Manager, too.
Tested this, and it works (and it is a welcome fix!), but, sorry, I'm not going to give this my official positive test as long as those !important
declarations are there. After all, forgive me the the pun, they don't seems to be important...
Also, in /media/com_finder/css/finder.css
a last blank line seems to be missing (Isn't this amongst our CS requirements? Am I wrong? Is it for PHP only? Travis not catching this?)
Tested on Opera 30.0.1835.125 / Win 10 Insider Preview Build 10074 #jquery15
I have applied patch and tested successfully in #jquery15 hackathon. We got it fixed. But there are other pages which is having issue. For Example: Frontend Editing Page. Not sure that should be fixed in the same PR.
Tested on chrome 43.0.2357.134 #jqconf15
Steps followed:
Works fine here on Macintosh, all browsers.
My test on Chrome (W8) was successfully.
First i checked the code fragment before applying it, then after applying it.
After recognizing the change of code, i tested the view at the backend.
First the dropdown has been cut off, afterwards it was correctly displayed behind the bar.
Tested with smart search and worked (Windows 8 Waterfox).
Small issue is:
If the dropdown-menu is open, it's not possible to close it again
by clicking on the button opening it. You have to click on the site outside
the dropdown menu.
Status | Pending | ⇒ | Information Required |
As stated above this appears to have been fixed elsewhere. Can you please confirm if it has indeed been fixed (looks like it to me) and then we can close this.
Hello @designbengel
Thank you for your contribution.
The last comment here was on November 18th. So the question is, Is this issue/pull request still valid?
If no reply is received within 4 weeks we will close this issue.
Thanks for understanding!
Hello @roland-d
The Issue still exists in 3.4.6 but i´ll take a look at 3.5 next days and let you know :) thanks!
Issue seems fixed in 3.5 :)
@designbengel So we can close this. I will close this PR, if it needs further attention it can always be opened later on. Thank you all for your contributions.
Status | Information Required | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-15 09:55:33 |
Closed_By | ⇒ | roland-d |
From my test on this your solution worked for me in Safari and chrome on OSX
As you have edited the template.css then you will need to make the change in the less file
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7182.