? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
12 Jun 2015

This PR adds tooltips to four more views. Similar to what is done in #7150.

Testing

Please note that this PR needs #7150 applied as well.
Check the search input field in the following manager views and verify that there is now a tooltip after the PR is applied. Before there was none.

  • Banners -> Banners
  • Banners -> Clients
  • Content -> Featured Articles
  • Users -> User Manager

If you find other views where there are Search Tools and the search field doesn't show anything, feel free to note.
The only one I found is the category manager, but there I didn't found the correct string. So either I'm blind or there is none.

avatar Bakual Bakual - open - 12 Jun 2015
avatar zero-24 zero-24 - change - 12 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 12 Jun 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 12 Jun 2015

Category doesn't but it should :)

avatar zero-24 zero-24 - change - 12 Jun 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 12 Jun 2015
Status New Pending
Easy No Yes
avatar Bakual
Bakual - comment - 12 Jun 2015

@brianteeman Feel free to propose a new language string for it :+1:
Since you want to standardise the strings anyway, you could include that in your future PR. Just add it as a description to the XML here: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_categories/models/forms/filter_categories.xml#L7

avatar brianteeman
brianteeman - comment - 12 Jun 2015

As we are in language string freeze it will have to wait :(
On 12 Jun 2015 2:33 pm, "Thomas Hunziker" notifications@github.com wrote:

@brianteeman https://github.com/brianteeman Feel free to propose a new
language string for it [image: :+1:]
Since you want to standardise the strings anyway, you could include that
in your future PR. Just add it as a description to the XML here:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_categories/models/forms/filter_categories.xml#L7


Reply to this email directly or view it on GitHub
#7163 (comment).

avatar n9iels
n9iels - comment - 12 Jun 2015

@test works fine for me


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7163.

avatar n9iels n9iels - test_item - 12 Jun 2015 - Tested successfully
avatar designbengel designbengel - test_item - 12 Jun 2015 - Tested successfully
avatar jwaisner
jwaisner - comment - 13 Jun 2015

@test

With both PRs applied everything works as intended.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7163.

avatar jwaisner jwaisner - test_item - 13 Jun 2015 - Tested successfully
avatar Bakual Bakual - change - 13 Jun 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 13 Jun 2015

Multiple good tests thanks - setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7163.

avatar brianteeman brianteeman - change - 13 Jun 2015
Status Pending Ready to Commit
avatar wilsonge wilsonge - change - 14 Jun 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-06-14 21:52:35
Closed_By wilsonge
avatar wilsonge wilsonge - close - 14 Jun 2015
avatar zero-24 zero-24 - close - 14 Jun 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment