[#7156] - Remove unnecessary conditional check in category and article views
- Closed
- 12 Jun 2015
- Medium
- Build: staging
- # 7156
- Diff
- joomdonation:patch-15
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
PR Summary
This PR simply remove unnecessary condition check in elseif command. That check always return true (if it return false, the code in if block will be run), so it is not needed.
Testing
This can be seen easily from code review. So I think we just need to a maintainer to review and merge it.
I will do the the same modification for other components (has this same unnecessary code) if this PR is approved.
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
zero-24
- | Category | ⇒ | Components |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Ready to Commit |
Thanks Thomas for reviewing the code. I made the same fix for other views and a small bug fix (in my last commit). Please help review it again.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-12 12:17:05 |
| Closed_By | ⇒ | Bakual |
Merged into staging, however without your last commit which is a complete unrelated change.
Please do a new PR with that fix as that one needs to be tested. Currently, the id always will be 0 (since $menu isn't defined). After your change it will have a value which may change the following checks.
Also the suppressed error (@$menu->query['id']) should be removed. If $menu isn't defined, we have a problem in the code we actually want to see 
OK :D. For some reasons, your commit seems doesn't include the fix for article view? Could you check it or should I do it again for article view ?
Hmm, I didn't include the commit which you reverted with "Sorry, I updated wrong file before".
Feel free to create a new PR for that, I can merge it on review as well.
| Labels |
Removed:
?
|
||
RTC based on review. Needs to be squashed before merging.