? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
11 Jun 2015

Originated and discussed in #7146

This PR adds back the tooltip for the search input element in views featuring Search Tools. It takes the value for the tooltip from the XML file specifying the filters.

To test just hover over the search input element and see that there is now a tooltip in articles and menuitems view. The other views remain unchanged.

avatar Bakual Bakual - open - 11 Jun 2015
avatar Bakual
Bakual - comment - 11 Jun 2015

This can obviously be expanded to other views where such strings are present and used to be shown.

avatar brianteeman
brianteeman - comment - 11 Jun 2015

My issue is that this is just masking an existing bug where the existing code to display this tooltip is not working


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7150.

avatar joomla-cms-bot joomla-cms-bot - change - 11 Jun 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jun 2015
Labels Added: ?
avatar Bakual
Bakual - comment - 11 Jun 2015

I think I figured out how it can work nicely. Using our API we can actually specify the selector for the tooltip (I knew that) and pass the tooltip directly in the call (didn't knew that).

This way we can add the tip to the input element directly without any hacks.

avatar zero-24 zero-24 - change - 11 Jun 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 11 Jun 2015
Status New Pending
avatar designbengel
designbengel - comment - 11 Jun 2015

can you post a screenshot of what you are expecting? I have no tooltip on search input. :/


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7150.

avatar brianteeman
brianteeman - comment - 11 Jun 2015

That's the problem. The tooltip that should display as per the existing
code does nothing! See the original issue for screenshots
On 11 Jun 2015 9:11 pm, "designbengel" notifications@github.com wrote:

can you post a screenshot of what you are expecting? I have no tooltip on

search input. :/

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/7150
http://issues.joomla.org/tracker/joomla-cms/7150.


Reply to this email directly or view it on GitHub
#7150 (comment).

avatar Bakual
Bakual - comment - 11 Jun 2015

can you post a screenshot of what you are expecting? I have no tooltip on search input. :/

Unfortunately, the screenshot tool I have doesn't allow me to take pictures of tooltips. So I would first have to figure out how to do that :smile:
Look at the search input field in the articles and menuitems managers. Currently there is no tooltip, after the PR is applied you should see a tooltip explaining the options you can use to search.

avatar designbengel
designbengel - comment - 11 Jun 2015

uhm yes sorry - it works. I was searching in frontend for the tooltips, altough it´s not labeled with frontend :smiley:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7150.

avatar designbengel designbengel - test_item - 11 Jun 2015 - Tested successfully
avatar jwaisner
jwaisner - comment - 12 Jun 2015

@test

PR works as expected. Tooltips now exist.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7150.

avatar jwaisner jwaisner - test_item - 12 Jun 2015 - Tested successfully
avatar zero-24 zero-24 - change - 12 Jun 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 12 Jun 2015

RTC based on testing. Maybe @Bakual can expand this changes also to the other components with a seccond?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7150.

avatar zero-24 zero-24 - change - 12 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 12 Jun 2015
Labels Added: ?
avatar Bakual
Bakual - comment - 12 Jun 2015

Will do also for the other views. Did anyone already have done a search which other views are affected :smile:

avatar brianteeman
brianteeman - comment - 12 Jun 2015

Yes. All the list views have this problem.
When you have done it I will do another pr to standardise the strings
On 12 Jun 2015 11:52, "Thomas Hunziker" notifications@github.com wrote:

Will do also for the other views. Did anyone already have done a search
which other views are affected [image: :smile:]


Reply to this email directly or view it on GitHub
#7150 (comment).

avatar Bakual
Bakual - comment - 12 Jun 2015

I'll have a look then.

avatar Bakual
Bakual - comment - 12 Jun 2015

Squashed my commits so it can be merged easily.

avatar Bakual
Bakual - comment - 12 Jun 2015

See #7163 for the missing views.

avatar wilsonge wilsonge - change - 14 Jun 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-06-14 21:53:02
Closed_By wilsonge
avatar wilsonge wilsonge - close - 14 Jun 2015
avatar wilsonge wilsonge - reference | 924e4fa - 14 Jun 15
avatar wilsonge wilsonge - merge - 14 Jun 2015
avatar wilsonge wilsonge - close - 14 Jun 2015
avatar zero-24 zero-24 - close - 14 Jun 2015
avatar wilsonge wilsonge - change - 14 Jun 2015
Milestone Added:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment