[#7147] - # Output the custom tags - array_unique makes sure that we don't outp…
- Closed
- 11 Jul 2015
- Medium
- Build: staging
- # 7147
- Diff
- compojoom:addCustomTag
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
…ut the same tags twice
In lib_compojoom we have few layouts for social share:
https://github.com/compojoom/lib_compojoom/tree/master/source/libraries/compojoom/layouts/social/share
I've implemented the open graph requirements to properly share an item in the facebook layout:
https://github.com/compojoom/lib_compojoom/blob/master/source/libraries/compojoom/layouts/social/share/facebook.php
And I was about the to do the same for the gplus layout as one could use the layouts separately. Google plus is reading open graph data, so basically I could output the same stuff on the page.
Due to my use of $document->addCustomTag whenever I call
$document->addCustomTag('<meta property="og:url" content="' . JURI::current() . '" />');
$document->addCustomTag('<meta property="og:url" content="' . JURI::current() . '" />');This would be added to the head twice. Which I think is not necessary. At the end we don't see the same behavior when we use JHtml::script or stylesheet? That's why I've changed the
fetchHead function to just output unique values from the custom array:
https://github.com/joomla/joomla-cms/compare/staging...compojoom:addCustomTag?expand=1#diff-ed74c9a4d3ec7e43b62b75c502e3787dL241
How to test?
Let's take a component view. for example:
\components\com_content\views\article\tmpl\default.php right after the defined call add:
$document = JFactory::getDocument();
$document->addCustomTag('<meta property="og:url" content="' . JURI::current() . '" />');
$document->addCustomTag('<meta property="og:url" content="' . JURI::current() . '" />');without the patch this should output the og:url meta property twice in the head (in single view of article). With the patch you should see the og:url tag just once.
| Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
Works as intended.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7147.
| Status | Pending | ⇒ | Ready to Commit |
RTC Thanks 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7147.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
mbabker
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-11 14:54:09 |
| Closed_By | ⇒ | mbabker |
| Labels |
Removed:
?
|
||
#test works as expected. No duplicated tags.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7147.