? Success
Pull Request for # 7132

User tests: Successful: Unsuccessful:

avatar designbengel
designbengel
8 Jun 2015

http://issues.joomla.org/tracker/joomla-cms/7132
Added css to fix overflowing input and select in modules. (Safari, Os X)

bildschirmfoto 2015-06-06 um 10 34 16

Test instructions:
1) Create a Smart Search Module (don´t forget to publish the smart search plugin first and index your content in smart search component)
2) turn filter on
3) check if select and labels are now shown right without overflowing.

// Need some help on fixing the alignment of label, input and button at the top

avatar designbengel designbengel - open - 8 Jun 2015
avatar zero-24 zero-24 - change - 8 Jun 2015
Category Front End UI/UX
avatar zero-24 zero-24 - change - 8 Jun 2015
Title
#7132 Added css styles
Smart Search module messed up when Parameters are on
Status New Pending
Rel_Number 7132
Relation Type Pull Request for
avatar zero-24 zero-24 - change - 8 Jun 2015
Title
#7132 Added css styles
Smart Search module messed up when Parameters are on
avatar dgt41
dgt41 - comment - 8 Jun 2015

@designbengel if it helps you can append a button in an input with bootstrap, here is a jfiddle that demonstrates that:
http://jsfiddle.net/KyleMit/R7Kzx/

avatar zero-24 zero-24 - change - 8 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 8 Jun 2015
Labels Added: ?
avatar designbengel
designbengel - comment - 8 Jun 2015

@dgt41 thank you but that don´t work for me either... and it must be according to the settings in module
label: top, left, right, bottom and/or
button: top, left, right, bottom - don´t know how how to fix that to be most flexible even when user changes the label and on...
bildschirmfoto 2015-06-08 um 22 38 55

avatar dgt41
dgt41 - comment - 8 Jun 2015

@designbengel are you referring to the label or the button or both?
Sorry just open the file and saw that there’s too much flexibility there. Personal opinion: if button is enabled append it to the input (forget all the other positions) and fix the label as left above!

avatar designbengel
designbengel - comment - 8 Jun 2015

Should i also remove options from module parameters then? (sorry, thats my first commit)

avatar dgt41
dgt41 - comment - 8 Jun 2015

@designbengel just realized that I have a PR that corrects the selects ???? but still the button and the input needs some attention
screenshot 2015-06-09 00 01 09

It would be great if you can improve that code #6322 so things won’t overlap ????

avatar designbengel
designbengel - comment - 8 Jun 2015

but #6322 is actually reffering to backend forms, doesn´t it?

avatar dgt41
dgt41 - comment - 8 Jun 2015

It also touches the code for those selects on the advanced search, com finder is kinda weird

avatar designbengel
designbengel - comment - 8 Jun 2015

Ok, let´s fix this together... :-)

avatar dgt41
dgt41 - comment - 8 Jun 2015

@designbengel can you try #6322 ?
The positioning for the label and button is now fixed: label above, button at the end of the field

avatar designbengel
designbengel - comment - 8 Jun 2015

Yes looks nice now! Just seems that a div is not closed or something
bildschirmfoto 2015-06-09 um 00 44 47

avatar watchfulli-dev
watchfulli-dev - comment - 9 Jun 2015

@test After applied the patch it seams okay, the search fields are not anymore overflowing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7140.

avatar watchfulli-dev watchfulli-dev - test_item - 9 Jun 2015 - Tested successfully
avatar designbengel
designbengel - comment - 9 Jun 2015

@dgt41 what to do next? closing this issue and use yours or implementing yours in mine? :-)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7140.

avatar brianteeman
brianteeman - comment - 9 Jun 2015

Looks good to me in both protostar and beez


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7140.

avatar brianteeman brianteeman - test_item - 9 Jun 2015 - Tested successfully
avatar roland-d roland-d - change - 9 Jun 2015
Milestone Added:
avatar dgt41
dgt41 - comment - 9 Jun 2015

@designbengel can you base your changes here to #6322 so we don’t fix this twice?

avatar roland-d roland-d - change - 9 Jun 2015
Milestone Removed:
avatar designbengel
designbengel - comment - 9 Jun 2015

@dgt41 in fact you fixed the issue but i see it overlaying at bottom now - let´s close this issue and i´ll send you a screen in #6322

avatar roland-d
roland-d - comment - 9 Jun 2015

Closing this PR as work is on-going in #6322 Thank you @designbengel for your contribution.

avatar roland-d roland-d - change - 9 Jun 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-06-09 18:45:14
Closed_By roland-d
avatar roland-d roland-d - close - 9 Jun 2015

Add a Comment

Login with GitHub to post a comment