User tests: Successful: Unsuccessful:
http://issues.joomla.org/tracker/joomla-cms/7132
Added css to fix overflowing input and select in modules. (Safari, Os X)
Test instructions:
1) Create a Smart Search Module (don´t forget to publish the smart search plugin first and index your content in smart search component)
2) turn filter on
3) check if select and labels are now shown right without overflowing.
// Need some help on fixing the alignment of label, input and button at the top
Category | ⇒ | Front End UI/UX |
Title |
|
||||||
Status | New | ⇒ | Pending | ||||
Rel_Number | ⇒ | 7132 | |||||
Relation Type | ⇒ | Pull Request for |
Title |
|
Labels |
Added:
?
|
Labels |
Added:
?
|
@dgt41 thank you but that don´t work for me either... and it must be according to the settings in module
label: top, left, right, bottom and/or
button: top, left, right, bottom - don´t know how how to fix that to be most flexible even when user changes the label and on...
@designbengel are you referring to the label or the button or both?
Sorry just open the file and saw that there’s too much flexibility there. Personal opinion: if button is enabled append it to the input (forget all the other positions) and fix the label as left above!
Should i also remove options from module parameters then? (sorry, thats my first commit)
@designbengel just realized that I have a PR that corrects the selects
It would be great if you can improve that code #6322 so things won’t overlap
It also touches the code for those selects on the advanced search, com finder is kinda weird
Ok, let´s fix this together... :-)
@designbengel can you try #6322 ?
The positioning for the label and button is now fixed: label above, button at the end of the field
@test After applied the patch it seams okay, the search fields are not anymore overflowing
@dgt41 what to do next? closing this issue and use yours or implementing yours in mine? :-)
Looks good to me in both protostar and beez
Milestone |
Added: |
@designbengel can you base your changes here to #6322 so we don’t fix this twice?
Milestone |
Removed: |
Closing this PR as work is on-going in #6322 Thank you @designbengel for your contribution.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-09 18:45:14 |
Closed_By | ⇒ | roland-d |
@designbengel if it helps you can append a button in an input with bootstrap, here is a jfiddle that demonstrates that:
http://jsfiddle.net/KyleMit/R7Kzx/