[#7136] - Fixes duplicate queries from MultilangstatusHelper
- Closed
- 13 Jul 2015
- Medium
- Build: staging
- # 7136
- Diff
- smz:MultilangstatusHelper
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Description
several methods from MultilangstatusHelper are called multiple times in the life of a Joomla! process.
This PR optimize this by locally caching the results
Testing procedure
- Use a multilingual site
- Verify that everything is "business as usual" (a.k.a: SNAFU...
) with and without this PR, both in the front-end and in the back-end. - Turn on Joomla Debug in global configuration and verify that several duplicated queries are now gone.
Even better: apply this together with #7137 and follow testing instruction there. If OK, you can give "@test OK" to both PRs
Additional comments
Thanks to "Viper" and "Robert G Mears" that have brought duplicate queries to my attention.
This might be a first in a series...
... so far I can't see any issues generated by this...
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Multilanguage |
| Status | New | ⇒ | Pending |
Should we reserve the same treatment to all queries in this class?
| Title |
|
||||||
| Title |
|
||||||
In Joomla Issues this results as "Pending" ( The Travis CI build is in progress), but actually Travis did his job already...
I have not tested, but please do not delete the comments for each function.
The comments I'm removing are repetition of what is indicated just a couple of lines above in the docbloc... Do you really want me to reinstate them?
No need, you are right.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-13 08:10:04 |
| Closed_By | ⇒ | smz |
I'm really unsure if this may have nasty side effects in the backend if/when you publish/unpublish languages... I should have tested that...