[#7126] - content plugins not able to insert custom fieldsets into core forms
- Closed
- 21 Jul 2015
- Medium
- Build: staging
- # 7126
- Diff
- pollen8:admin-content-form-plugins
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is basically the work done in this previous PR
#4284
With the additions that Jean Marie asked for regarding multi lingual sites and the associations tab that is added.
The test instructions are the same as #4284
Background
With the implementation of using JLayout to render parameters (#2162) support for rendering custom named fieldsets ceased to be supported. This is a documented feature since at least Joomla 2.5 http://docs.joomla.org/Adding_custom_fields_to_the_article_component and is also documented to be suported in 3.1 at http://docs.joomla.org/Adding_custom_fields_to_core_components_using_a_plugin. In fact, the current core user profile plugin would break if JLayout 'joomla.edit.params' was implemented for com_users.user due to the plugin using custom named fieldsets (https://github.com/joomla/joomla-cms/blob/staging/plugins/user/profile/profiles/profile.xml#L3-L4) and the current implementation of JLayout 'joomla.edit.params' being effectively hardcoded to only render fieldsets named params and attribs (https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/edit/params.php#L15-L18).
Changes
This PR changes the behavior of JLayout 'joomla.edit.params' to render all fieldsets of the form, except those designated with the ignore_fieldsets property.
Affected by this PR are the following backend edit views:
- com_categories.category
- com_contact.contact
- com_content.article
- com_finder.filter
- com_menus.item
- com_modules.module
- com_newsfeeds.newsfeed
- com_plugins.plugin
- com_tags.tag
- com_templates.style
Backwards Compatibility
This PR should be 100% backwards compatible while restoring this functionality.
Testing
Apply the patch associated with this PR and review the above views to ensure that all of the currently rendered fieldsets (as tabs in Isis) remain to be rendered. Then, install and plugin that uses a custom named fieldset and ensure that it is rendered at all of the above views as described in Joomla's documentation.
A test plugin can be downloaded from https://github.com/betweenbrain/Joomla-Custom-Field-Plugin-Example/archive/test.zip
Votes
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration Layout |
@this works good
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7126.
Applied Patch -> Tag edit (/index.php?option=com_tags&view=tag&layout=edit) wrong or missing language string COM_TAGS_URLS_FIELDSET_LABEL
Also could not test com_weblinks - sorry, where can i get it, couldn´t find at JED ?
Then i installed your test-plugin and the custom named fieldset were shown like expected.
So just one small issue with the tag view...
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7126.
Also could not test com_weblinks - sorry, where can i get it, couldn´t find at JED ?
The JED Version is broken 
Please try the RC2 from here: https://github.com/joomla-extensions/weblinks/releases/download/3.4.1-rc2/pkg_weblinks_dev.zip until we have a final 3.4.2 of weblinks 
Decoupled Extensions (later also e.g. messages, banners etc.) can be found here: http://extensions.joomla.org/extensions/extension/official-extensions/
@designbengel Thanks for pointing that out. That fieldset was being added twice. It should render just a hidden field at the bottom of the form, so I've added it to the ignore_fieldsets array to avoid it being rendered as a tab.
@designbengel if you could retest once more then we will have 2 successful tests :)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7126.
Yes, now everything is fine :)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7126.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
Yeah! I've got that warm Friday Joomla feeling - thanks everyone for testing
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-21 08:54:33 |
| Closed_By | ⇒ | Kubik-Rubik |
joomla-cms-bot
- | Labels |
Removed:
?
|
||
Thank you @pollen8 and @betweenbrain! Merged with 580bec7.
#7582 is now merged
I wonder, concerning the other places where it has been added in this PR if is not missing
$this->fieldsets = array();
before using
// Fieldsets to not automatically render by /layouts/joomla/edit/params.php
$this->ignore_fieldsets = array('item_associations');
instead of placing this code on top of file without defining $this->fieldsets.
Thank you for doing this :)