? ?

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Jun 2015

This PR adds some consistency to the text in the tooltips for all media type fields. They now all indicate that you can select and upload an image with this field

avatar brianteeman brianteeman - open - 4 Jun 2015
avatar brianteeman brianteeman - change - 4 Jun 2015
Category Language & Strings
avatar wilsonge wilsonge - change - 4 Jun 2015
Labels Added: ? ?
avatar wilsonge wilsonge - change - 4 Jun 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 4 Jun 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2015
Labels Added: ?
avatar wilsonge
wilsonge - comment - 4 Jun 2015

RTC

avatar brianteeman brianteeman - change - 4 Jun 2015
Status New Ready to Commit
avatar wilsonge
wilsonge - comment - 5 Jun 2015

This has conflicts - please can you merge in staging :)

avatar brianteeman
brianteeman - comment - 5 Jun 2015

My git skills are not good - can you help me

avatar wilsonge
wilsonge - comment - 5 Jun 2015

Do you have git set up on a command line? (this is where that reverted commit is going to bite your ass)

avatar brianteeman
brianteeman - comment - 5 Jun 2015

i do yes but I usually just use the github mac client which is what causes issues

avatar brianteeman
brianteeman - comment - 5 Jun 2015

tried and failed to find resolve the conflicts - any help appreciated

avatar wilsonge
wilsonge - comment - 5 Jun 2015

I'm halfway through a long explanation. But just had an idea I can try to fix things first - two minutes!

avatar brianteeman
brianteeman - comment - 5 Jun 2015

Thanks - next time I wont use the mac client - it is harder to fix stuff with the gui than the cli

avatar wilsonge wilsonge - reference | 60da74b - 5 Jun 15
avatar wilsonge
wilsonge - comment - 5 Jun 2015

OK I think I've got it - can you just confirm for me for my own piece of mind this commit does the same thing as this PR wilsonge@60da74b

avatar brianteeman
brianteeman - comment - 5 Jun 2015

THANKS!!!!

Almost correct - you introduced two new changes that I have commented on

avatar wilsonge wilsonge - close - 5 Jun 2015
avatar wilsonge
wilsonge - comment - 5 Jun 2015

WOOOT :D Merged fb3b9ce

avatar wilsonge wilsonge - change - 5 Jun 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-06-05 23:56:56
Closed_By wilsonge
avatar wilsonge wilsonge - close - 5 Jun 2015
avatar brianteeman brianteeman - reference | fb3b9ce - 5 Jun 15
avatar brianteeman brianteeman - head_ref_deleted - 5 Jun 2015
avatar zero-24 zero-24 - change - 6 Jun 2015
Milestone Added:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment